meta/sql: fix nil pointer in doBatchUnlink #6646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Fixes a nil-pointer panic in dbMeta.doBatchUnlink for SQL metadata backends by safely handling missing entries in the delNodes map (issue #6640).
Changes:
- Guarded access to
delNodes[info.n.Inode]by using a map existence check before reading.opened.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| entrySpace = align4K(info.n.Length) | ||
| needRecordStats = true | ||
| if delNodes[info.n.Inode].opened { | ||
| if dn, ok := delNodes[info.n.Inode]; ok && dn.opened { |
There was a problem hiding this comment.
Consider adding a regression test that exercises BatchUnlink/doBatchUnlink when m.sid == 0 (e.g., after NewSession(false) or without recording a session). This is the scenario that previously triggered the nil-pointer panic, and a focused test would prevent accidental reintroduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6640