Skip to content

meta/sql: fix nil pointer in doBatchUnlink #6646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xuyuchao-juice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

meta/sql: fix nil pointer in doBatchUnlink #6646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/meta/sql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2785,7 +2785,7 @@ func (m *dbMeta) doBatchUnlink(ctx Context, parent Ino, entries []*Entry, length
case TypeFile:
entrySpace = align4K(info.n.Length)
needRecordStats = true
if delNodes[info.n.Inode].opened {
if dn, ok := delNodes[info.n.Inode]; ok && dn.opened {
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression test that exercises BatchUnlink/doBatchUnlink when m.sid == 0 (e.g., after NewSession(false) or without recording a session). This is the scenario that previously triggered the nil-pointer panic, and a focused test would prevent accidental reintroduction.

Copilot uses AI. Check for mistakes.
sustainedIns = append(sustainedIns, &sustained{Sid: m.sid, Inode: info.e.Inode})
if _, err := s.Cols("nlink", "ctime", "ctimensec").Update(info.n, &node{Inode: info.n.Inode}); err != nil {
return err
Expand Down
Loading