chore: hint machine addresses as list of dicts #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `list[str]` has type-hinting made working with a type-checker awkward as an addresses is defined as a dict of mostly [str, str] key-values pairs, with one key-value being a [str, boolean] key-value pairs. Signed-off-by: Guillaume Boutry <[email protected]>
benhoyt
approved these changes
May 15, 2025
Collaborator
|
/build |
Collaborator
|
/merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having
list[str]has type-hinting made working with a type-checker awkward as an addresses is defined as a dict of mostly [str, str] key-values pairs, with one key-value being a [str, boolean] key-value pairs.QA Steps
Just a type hint change
Notes & Discussion
I chose not to type as
typing.List[typing.Dict[str, typing.Union[str, boolean]]]as it would make working with that type also awkward...python-libjuju/juju/client/schemas-juju-3.6.0.json
Line 10586 in fdbbbe9