Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses PHP 8.5 compatibility issues by fixing parameter types and avoiding deprecated functions.
Changes:
- Fixed
http_build_query()call to use empty string instead of null for the second parameter - Added version check to conditionally skip
curl_close()call to avoid deprecation warnings - Updated CHANGELOG with entries for both fixes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OpenIDConnectClient.php | Fixed http_build_query null parameter and added PHP version check for curl_close |
| CHANGELOG.md | Added changelog entries documenting both PHP 8.5 compatibility fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6086828 to
bd65e67
Compare
|
@DeepDiver1975 Is there any chance to get this merged? We just stumbled over the deprecation warnings which are going to be fixed by this MR when using this package with PHP 8.5. It would be great to tag a new release after merging this PR. |
|
@antoineveldhoven Additionally PHP 8.5 could be added to the build matrix in https://github.com/antoineveldhoven/OpenID-Connect-PHP/blob/bd65e67ea6aac201cb5390e4af16dfe9e1fead2e/.github/workflows/build.yml#L22-L24. WDYT? |
|
@DeepDiver1975 I created #501 based on this PR which additionally adds PHP 8.5 to the build matrix. |
http_build_query expects a string, null no longer allowed.
curl_close() since PHP 8.0.0 ineffective, since 8.5.0 deprecated.