Open
Conversation
Open
W0rma
commented
Mar 20, 2026
| } | ||
|
|
||
| // Convert token params to string format | ||
| $post_params = http_build_query($post_data, null, '&', $this->encType); |
Contributor
Author
There was a problem hiding this comment.
There is already #414 about this change.
I'm going to rebase if you prefer merging this PR beforehand.
Contributor
Author
|
The failing PHP 7.1 job is unrelated. Seems like One possible solution could be to drop support for PHP 7.1 in |
DeepDiver1975
approved these changes
Mar 24, 2026
Contributor
Author
|
@DeepDiver1975 PR rebased - merge conflicts are gone and the CI is green :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of common tasks a pull request require complete
This PR is based on #500 and adds PHP 8.5 to the build matrix.