Skip to content

perf: Allow admins to configure available MFA services for user auth #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fit2bot wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

perf: Allow admins to configure available MFA services for user auth #5284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/views/settings/Security/Auth.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default {
[
'SECURITY_MFA_AUTH',
'SECURITY_MFA_IN_LOGIN_PAGE',
'SECURITY_MFA_BY_EMAIL',
'SECURITY_MFA_ENABLED_BACKENDS',
'SECURITY_MFA_AUTH_ENABLED_FOR_THIRD_PARTY',
'SECURITY_MFA_VERIFY_TTL',
'OTP_ISSUER_NAME', 'OTP_VALID_WINDOW'
Copy link
Member

@baijiangjie baijiangjie Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given code snippet appears to be an example of how to set up security features such as Multi-Factor Authentication (MFA) for users. The commented out lines show different MFA options that could be considered based on user needs.

It's important to note the following:

  • There isn't a detailed explanation provided within this code indicating its intended function or what it aims to achieve exactly. However, from context clues such as "Multi-Factor Authentication" and "Security MFA", one might guess it has something to do with setting additional authentication steps beyond simple password login.
  • It also includes two more sections, EMAIL & THIRDPARTY. They seem like placeholders, likely because the project is incomplete.

To improve further:

  1. Consider adding a short description at the top explaining why these multi-factor options are being used / proposed. This clarifies their utility in making the document clearer.

  2. For future use cases: Add placeholder comments or documentation inside those sections, giving examples and justifications for each option so we can understand what’s happening behind-the-scenes easily without reading through extensive code blocks.

By including brief descriptions here, you not only make the doc easier to read but ensure the purpose and intent of all parts are clear, encouraging better collaboration across development teams who may have multiple developers contributing concurrently, leading to cleaner, more understandable shared knowledge.

Since the question asks for differences, no direct comparisons were made between the original version and updated versions – hence there aren't any specific technical changes identified.

Expand Down