Skip to content

Fix some upcoming NullAway wildcard warnings#5602

Open
msridhar wants to merge 1 commit intojunit-team:mainfrom
msridhar:nullaway-wildcard-warnings
Open

Fix some upcoming NullAway wildcard warnings#5602
msridhar wants to merge 1 commit intojunit-team:mainfrom
msridhar:nullaway-wildcard-warnings

Conversation

@msridhar
Copy link
Copy Markdown

We're starting to work on wildcard support in NullAway (see uber/NullAway#1520), and some warnings turned up when running that NullAway version on JUnit. This PR fixes the warnings. I think the fix makes sense: since ConfigurationParameters#get takes a Function<? super String, ? extends @Nullable T>, org.junit.jupiter.engine.config.JupiterConfiguration#getRawConfigurationParameter should take the same type for its Function parameter.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Most points N/A as this only changes annotations; no code behavior changes

Signed-off-by: Manu Sridharan <msridhar@gmail.com>
@msridhar msridhar force-pushed the nullaway-wildcard-warnings branch from 38afa29 to 1e12942 Compare April 13, 2026 01:12
@testlens-app
Copy link
Copy Markdown

testlens-app bot commented Apr 13, 2026

✅ All tests passed ✅

⚠️ TestLens detected flakiness ⚠️

Test Summary

Check Project/Task Test Runs
CI / macOS :jupiter-tests:test SeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded 🚫 ⚠️

🏷️ Commit: 1e12942
▶️ Tests: 17376 executed
⚪️ Checks: 15/15 completed

Test Failure

SeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in CI / macOS)
java.lang.AssertionError: 
Expecting code to raise a throwable.
	at org.junit.jupiter.engine.extension.SeparateThreadTimeoutInvocationTests.throwsTimeoutException(SeparateThreadTimeoutInvocationTests.java:50)

Learn more about TestLens at testlens.app.

Copy link
Copy Markdown
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants