Fix some upcoming NullAway wildcard warnings#5602
Open
msridhar wants to merge 1 commit intojunit-team:mainfrom
Open
Fix some upcoming NullAway wildcard warnings#5602msridhar wants to merge 1 commit intojunit-team:mainfrom
msridhar wants to merge 1 commit intojunit-team:mainfrom
Conversation
Signed-off-by: Manu Sridharan <msridhar@gmail.com>
38afa29 to
1e12942
Compare
✅ All tests passed ✅Test Summary
🏷️ Commit: 1e12942 Test FailureSeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in CI / macOS)Learn more about TestLens at testlens.app. |
mpkorstanje
requested changes
Apr 13, 2026
Contributor
mpkorstanje
left a comment
There was a problem hiding this comment.
@msridhar I think you'll want to look at https://github.com/junit-team/junit-framework/actions/runs/24321136370/job/71047522373?pr=5602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're starting to work on wildcard support in NullAway (see uber/NullAway#1520), and some warnings turned up when running that NullAway version on JUnit. This PR fixes the warnings. I think the fix makes sense: since
ConfigurationParameters#gettakes aFunction<? super String, ? extends @Nullable T>,org.junit.jupiter.engine.config.JupiterConfiguration#getRawConfigurationParametershould take the same type for itsFunctionparameter.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
Most points N/A as this only changes annotations; no code behavior changes
@APIannotations