Skip to content

Fix some upcoming NullAway wildcard warnings #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msridhar wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

Fix some upcoming NullAway wildcard warnings #5602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ter-engine/src/main/java/org/junit/jupiter/engine/config/CachingJupiterConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.util.function.Supplier;

import org.apiguardian.api.API;
import org.jspecify.annotations.Nullable;
import org.junit.jupiter.api.ClassOrderer;
import org.junit.jupiter.api.Constants;
import org.junit.jupiter.api.DisplayNameGenerator;
Expand Down Expand Up @@ -73,7 +74,8 @@ public Optional<String> getRawConfigurationParameter(String key) {
}

@Override
public <T> Optional<T> getRawConfigurationParameter(String key, Function<? super String, ? extends T> transformer) {
public <T> Optional<T> getRawConfigurationParameter(String key,
Function<? super String, ? extends @Nullable T> transformer) {
return delegate.getRawConfigurationParameter(key, transformer);
}

Expand Down
4 changes: 3 additions & 1 deletion ...ter-engine/src/main/java/org/junit/jupiter/engine/config/DefaultJupiterConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import java.util.function.Supplier;

import org.apiguardian.api.API;
import org.jspecify.annotations.Nullable;
import org.junit.jupiter.api.ClassOrderer;
import org.junit.jupiter.api.DisplayNameGenerator;
import org.junit.jupiter.api.MethodOrderer;
Expand Down Expand Up @@ -160,7 +161,8 @@ public Optional<String> getRawConfigurationParameter(String key) {
}

@Override
public <T> Optional<T> getRawConfigurationParameter(String key, Function<? super String, ? extends T> transformer) {
public <T> Optional<T> getRawConfigurationParameter(String key,
Function<? super String, ? extends @Nullable T> transformer) {
return configurationParameters.get(key, transformer);
}

Expand Down
4 changes: 3 additions & 1 deletion junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/config/JupiterConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import java.util.function.Supplier;

import org.apiguardian.api.API;
import org.jspecify.annotations.Nullable;
import org.junit.jupiter.api.ClassOrderer;
import org.junit.jupiter.api.DisplayNameGenerator;
import org.junit.jupiter.api.MethodOrderer;
Expand All @@ -41,7 +42,8 @@ public interface JupiterConfiguration {

Optional<String> getRawConfigurationParameter(String key);

<T> Optional<T> getRawConfigurationParameter(String key, Function<? super String, ? extends T> transformer);
<T> Optional<T> getRawConfigurationParameter(String key,
Function<? super String, ? extends @Nullable T> transformer);

boolean isParallelExecutionEnabled();

Expand Down
Loading