Update template tests for new @jupyter/builder default#115
Merged
Conversation
Darshan808
changed the title
@jupyter/builder default
Darshan808
commented
Jun 11, 2026
Comment on lines
+268
to
+269
| # incompatibility check can only be verified on `@jupyterlab/builder` for | ||
| # now. So we remove `@jupyter/builder` and pin `@jupyterlab/builder` to an |
Member
Author
There was a problem hiding this comment.
This is because, we don't have enough versions published yet to test for incompatibility using @jupyter/builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
Description
The extension template now ships
@jupyter/builderby default and no longer includes@jupyterlab/builder. Since@jupyter/builderis the preferred builder marker, our tests needed updating:@jupyter/builderexplicitly — the template provides it now.*_jupyterlab_buildertests now swap in@jupyterlab/builderand remove@jupyter/builderso they actually exercise thejupyterlab/builderpath.