Skip to content

Fix ystore imports after module moved to pycrdt.store #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Darshan808
Copy link
Member

This PR updates the imports for YStore and websocket to reflect their new location in the pycrdt.store and pycrdt.websocket module, after YStore being moved from pycrdt_websocket to https://github.com/y-crdt/pycrdt-store in y-crdt/pycrdt-websocket#123

Copy link
Contributor

Binder 👈 Launch a Binder on branch Darshan808/jupyter-collaboration/ystore-import-fix

@Darshan808
Copy link
Member Author

I think we need to update the version of pycrdt-websocket too

@krassowski
Copy link
Member

I think pycrdt-store also needs to be added to:

dependencies = [
"jupyter_server>=2.15.0,<3.0.0",
"jupyter_ydoc>=2.1.2,<4.0.0,!=3.0.0,!=3.0.1",
"pycrdt",
"pycrdt-websocket>=0.15.0,<0.16.0",
"jupyter_events>=0.11.0",
"jupyter_server_fileid>=0.7.0,<1",
"jsonschema>=4.18.0"
]

and

additional_dependencies: [tornado, pytest, pycrdt-websocket]

@Darshan808
Copy link
Member Author

Note

pre-commit hook will remain red until the corresponding fixes are merged in the following repositories:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants