Add ready: bool annotation to YRoom
#126
Conversation
| @@ -83,7 +83,7 @@ def __init__( | |||
| """ | |||
| self.ydoc = Doc() if ydoc is None else ydoc | |||
| self.ready_event = Event() | |||
| self.ready = ready | |||
| self.ready: bool = ready | |||
There was a problem hiding this comment.
Maybe really add the annotation at the class level above, as your comment says?
There was a problem hiding this comment.
That change caused a mypy error in the CI, likely because we already have a @property defined for it. You can check the details here
There was a problem hiding this comment.
The property and setter are already properly annotated as returning/taking bool, so I’m not sure why mypy is still complaining about this. To work around this, I think it’s simplest to add a class-level annotation and silence the redefinition error with a # type: ignore.
Isn't the CI failure in jupyterlab/jupyter-collaboration#480 expected, since it updates |
Ahh, I was missing that—thanks for the clarification! I'll go ahead and close this PR since it's not needed. |
Adds a ready: bool class‐level annotation to YRoom so mypy recognizes self.ready and the [has-type] error goes away.
CI error: https://github.com/jupyterlab/jupyter-collaboration/actions/runs/14774032452/job/41478969976?pr=480