Skip to content

chore: added explicit docker.io registry to all images in docker-compose.yml #9771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: added explicit docker.io registry to all images in docker-compose.yml #9771

wants to merge 2 commits into from
+36 −38

Conversation

Shailesh-714
Copy link
Contributor

@Shailesh-714 Shailesh-714 commented Oct 9, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added docker.io registry prefix to all images in the docker-compose.yml to avoid confusions when the host machine has a different default registry set.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This pr fixes this issue #9187 (comment)

How did you test it?

Ran docker-compose up for all services:
Screenshot 2025-10-09 at 6 09 01 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Shailesh-714 Shailesh-714 self-assigned this Oct 9, 2025
@Shailesh-714 Shailesh-714 requested a review from a team as a code owner October 9, 2025 12:40
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 9, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  docker-compose-development.yml  0% smaller
  docker-compose.yml  0% smaller

@Shailesh-714 Shailesh-714 linked an issue Oct 9, 2025 that may be closed by this pull request
[TASK] Add docker.io prefix to all images in docker-compose.yml #9772
Open
SanchithHegde
SanchithHegde reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same change in the docker-compose-development.yml file as well?

@Shailesh-714 Shailesh-714 requested a review from a team as a code owner October 10, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Pradesh-S Pradesh-S Pradesh-S approved these changes

Assignees

@Shailesh-714 Shailesh-714

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TASK] Add docker.io prefix to all images in docker-compose.yml

3 participants

@Shailesh-714 @SanchithHegde @Pradesh-S