Skip overriding url key if "empty" #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudio-ferraro
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR modifies a SQL query in the CategoryExist plugin to exclude empty values when checking for category URL keys. The change adds a condition to filter out records where the EAV (Entity-Attribute-Value) value is an empty string.
- Adds a filter condition to exclude empty URL key values in the category existence check
| FROM eav_entity_type | ||
| WHERE entity_type_code = 'catalog_category' | ||
| ) | ||
| AND eav.`value` != '' |
There was a problem hiding this comment.
Consider using IS NOT NULL AND TRIM(eav.value) != '' instead of just != '' to handle whitespace-only values and null values more comprehensively.
Suggested change
| AND eav.`value` != '' | |
| AND eav.`value` IS NOT NULL AND TRIM(eav.`value`) != '' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.