Skip to content

Skip overriding url key if "empty" #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimruiter merged 1 commit into from
Aug 1, 2025
Merged

Skip overriding url key if "empty" #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Plugin/CategoryExist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public function beforeSetValues()
FROM eav_entity_type
WHERE entity_type_code = 'catalog_category'
)
AND eav.`value` != ''
Copy link

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using IS NOT NULL AND TRIM(eav.value) != '' instead of just != '' to handle whitespace-only values and null values more comprehensively.

Suggested change
AND eav.`value` != ''
AND eav.`value` IS NOT NULL AND TRIM(eav.`value`) != ''

Copilot uses AI. Check for mistakes.
)
AND eav.store_id = {$store['store_id']}
)
Expand Down