Skip to content

Conversation

@joachimVT
Copy link
Contributor

Convert all implicit nullable parameters to explicit nullable type hints (?type) to resolve PHP 8.4 deprecation warnings across AkeneoBundle

…nts (?type) to resolve PHP 8.4 deprecation warnings across AkeneoBundle
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses PHP 8.4 deprecation warnings by converting implicit nullable parameters (where default value is null without explicit nullable type hint) to explicit nullable type hints across the AkeneoBundle codebase.

  • Adds explicit nullable type hints (?Type) to parameters with null default values
  • Updates method signatures in Plugin, Job, Helper, and Console Command classes
  • Ensures PHP 8.4 compatibility by following the new strict typing requirements

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Plugin/Helper/Import/Product.php Updates $family parameter to use mixed type with null default
Job/SlackMessage.php Adds nullable Collection type hints for $errorLogs and $processingLogs parameters
Job/SetNotVisible.php Adds nullable OutputInterface type hint for $output parameter
Job/RunSlackMessage.php Adds nullable type hints for both $input and $output parameters
Job/ImportMetricUnits.php Adds nullable OutputInterface type hint for $output parameter
Helper/SlackHelper.php Adds nullable int type hints for $storeId parameters in two methods
Console/Command/SlackNotificationCommand.php Adds nullable string type hint for $name parameter in constructor
Console/Command/SetNotVisible.php Adds nullable string type hint for $name parameter in constructor
Console/Command/ImportMetricUnits.php Adds nullable string type hint for $name parameter in constructor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claudio-ferraro
Copy link
Member

Thank you for improving PHP 8.4 support. Really appreciate your contribution!

@claudio-ferraro claudio-ferraro merged commit 83f8d12 into justbetter:master Nov 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants