Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Console/Command/ImportMetricUnits.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ImportMetricUnits extends Command
{
protected ImportMetricUnitsJob $job;

public function __construct(ImportMetricUnitsJob $job, string $name = null)
public function __construct(ImportMetricUnitsJob $job, ?string $name = null)
{
$this->job = $job;

Expand Down
2 changes: 1 addition & 1 deletion Console/Command/SetNotVisible.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SetNotVisible extends Command
{
protected SetNotVisibleJob $job;

public function __construct(SetNotVisibleJob $job, string $name = null)
public function __construct(SetNotVisibleJob $job, ?string $name = null)
{
$this->job = $job;

Expand Down
2 changes: 1 addition & 1 deletion Console/Command/SlackNotificationCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class SlackNotificationCommand extends Command
{
protected $runSlackMessage;

public function __construct(RunSlackMessage $runSlackMessage, $name = null)
public function __construct(RunSlackMessage $runSlackMessage, ?string $name = null)
{
$this->runSlackMessage = $runSlackMessage;
parent::__construct($name);
Expand Down
4 changes: 2 additions & 2 deletions Helper/SlackHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class SlackHelper extends AbstractHelper
* @param String $field
* @param Int $storeId
*/
public function getConfigValue($field, $storeId = null)
public function getConfigValue($field, ?int $storeId = null)
{
return $this->scopeConfig->getValue(
$field,
Expand All @@ -28,7 +28,7 @@ public function getConfigValue($field, $storeId = null)
* @param String $code
* @param null $storeId
*/
public function getGeneralConfig($code, $storeId = null)
public function getGeneralConfig($code, ?int $storeId = null)
{
return $this->getConfigValue(self::XML_PATH . $code, $storeId);
}
Expand Down
2 changes: 1 addition & 1 deletion Job/ImportMetricUnits.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function __construct(
$this->config = $config;
}

public function execute(OutputInterface $output = null): void
public function execute(?OutputInterface $output = null): void
{
if (! $this->authenticator->getAkeneoApiClient()) {
if ($output) {
Expand Down
2 changes: 1 addition & 1 deletion Job/RunSlackMessage.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class RunSlackMessage
protected $logs;
protected $slackMessage;

public function execute(InputInterface $input = null, OutputInterface $output = null)
public function execute(?InputInterface $input = null, ?OutputInterface $output = null)
{
$message = $this->getMessage();
if ($this->helperData->isEnable()) {
Expand Down
2 changes: 1 addition & 1 deletion Job/SetNotVisible.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function __construct(CollectionFactory $collectionFactory, ScopeConfigInt
$this->action = $action;
}

public function execute(OutputInterface $output = null): void
public function execute(?OutputInterface $output = null): void
{
$products = $this->collectionFactory->create()
->addFieldToFilter('attribute_set_id', ['in' => $this->getNotVisibleFamilies()])
Expand Down
2 changes: 1 addition & 1 deletion Job/SlackMessage.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function success()
* @param Collection $processingLogs
* @return string
*/
public function warning(Collection $errorLogs = null, Collection $processingLogs = null)
public function warning(?Collection $errorLogs = null, ?Collection $processingLogs = null)
{
$message = ':warning: *Warning!* There\'s a problem with today’s imports in *' . $this->store->getName()
. "*.\n\n";
Expand Down
2 changes: 1 addition & 1 deletion Plugin/Helper/Import/Product.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public function __construct(
) {
}

public function beforeCreateTmpTableFromApi($subject, $result, $tableSuffix, $family = null)
public function beforeCreateTmpTableFromApi($subject, $result, $tableSuffix, mixed $family = null)
{
if (is_null($this->codes)) {
$this->codes = explode(',', (string)$this->config->getValue('akeneo_connector/justbetter/important_attributes'));
Expand Down