-
Notifications
You must be signed in to change notification settings - Fork 76
Moved sentry logging to a monolog handler #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apply fixes from StyleCI
…to2-sentry into feature/monolog-handler
Apply fixes from StyleCI
…to2-sentry into feature/monolog-handler
- Logger/Handler/Sentry.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're housing a version for V2 and V3 PHPStan will never be happy
When testing this, I'm seeing this error;
It used to be okay to leave this field empty, but now I have to explicitly declare it in env.php. |
I'm also running into a circular dependency error: And an Area code not set error on the frontend. After disabling the Sentry extension everything works just fine. |
This should be fixed now
Unfortunately i don't see that happening on my side, do you have an extended stack trace on those? |
Apply fixes from StyleCI
…to2-sentry into feature/monolog-handler
Apply fixes from StyleCI
I've tested this on Magento 2.4.7 and 2.4.8 and it works for both. |
Summary
In order to improve update survivability this PR moves the monolog handlers away from a preference and into it's own handler
Result
Functionality wise everything will stay the same, but since we're in a handler now we no longer need to worry about type changes on addRecord
Checklist
composer run codestyle
composer run phpstan