fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error#2653
fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error#2653
Conversation
[Fixed] - onChange event value property type error
🦋 Changeset detectedLatest commit: 73278b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
/snapit |
|
Starting a new snapshot build. You can view the logs here. |
|
@siggerzz Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-checkbox-group@0.0.0-snapshot-release-20260115115640 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260115115640 --mode=update-lockfileThen finally: yarn install |
|
Thanks for originally raising this @cameronmcnaught! Would you be happy to test one of the npm snapshots to see if the issue is fixed? I think in your case, you were using the Let us know if you run into any problems! |
Describe your changes (can list changeset entries if preferable)
Fixes #2641 by omitting onChange from React.FieldsetsHTMLAttributes to avoid type conflicts with the component's custom event handling. This follows the same pattern established in PR #2327 for other form components.
This PR was originally raised by @AZEEMAZAM1, but re-raising with preserved commit history as our CI doesn't run in forks 👍🏼
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.