Skip to content

fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error#2653

Open
siggerzz wants to merge 3 commits intomainfrom
dsw-123-checkbox-onchange-fix
Open

fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error#2653
siggerzz wants to merge 3 commits intomainfrom
dsw-123-checkbox-onchange-fix

Conversation

@siggerzz
Copy link
Copy Markdown
Contributor

@siggerzz siggerzz commented Jan 15, 2026

Describe your changes (can list changeset entries if preferable)

Fixes #2641 by omitting onChange from React.FieldsetsHTMLAttributes to avoid type conflicts with the component's custom event handling. This follows the same pattern established in PR #2327 for other form components.

This PR was originally raised by @AZEEMAZAM1, but re-raising with preserved commit history as our CI doesn't run in forks 👍🏼

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have reviewed visual test updates properly before approving.
  • I have added thorough tests where applicable (unit / component / visual).

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 15 deployment 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

…rror

Fixes #2641 by omitting onChange from React.FieldsetsHTMLAttributes to avoid type conflicts with the component's custom event handling. This follows the same pattern established in PR #2327 for other form components.
[Fixed] - onChange event value property type error
@siggerzz siggerzz requested a review from a team as a code owner January 15, 2026 11:44
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 15, 2026

🦋 Changeset detected

Latest commit: 73278b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@justeattakeaway/pie-checkbox-group Patch
@justeattakeaway/pie-storybook Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siggerzz siggerzz changed the title Dsw 123 checkbox onchange fix fix(pie-checkbox-group): resolve onChange event value property type error Jan 15, 2026
@pie-design-system-bot
Copy link
Copy Markdown
Contributor

pie-design-system-bot commented Jan 15, 2026




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 73278b9

@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2653 January 15, 2026 11:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2653 January 15, 2026 11:48 Inactive
@siggerzz
Copy link
Copy Markdown
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@siggerzz siggerzz changed the title fix(pie-checkbox-group): resolve onChange event value property type error fix(pie-checkbox-group): DSW-123 resolve onChange event value property type error Jan 15, 2026
@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@siggerzz Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-checkbox-group@0.0.0-snapshot-release-20260115115640 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260115115640 --mode=update-lockfile

Then finally:

yarn install

@siggerzz siggerzz changed the title fix(pie-checkbox-group): DSW-123 resolve onChange event value property type error fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error Jan 15, 2026
@siggerzz
Copy link
Copy Markdown
Contributor Author

Thanks for originally raising this @cameronmcnaught!

Would you be happy to test one of the npm snapshots to see if the issue is fixed? I think in your case, you were using the pie-webc in your repo, so this is the only snapshot you'll need to install! 👍🏼

Let us know if you run into any problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PieCheckboxGroup] - Property 'value' does not exist on type 'EventTarget'

3 participants