Skip to content

fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siggerzz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(pie-checkbox-group): DSW-3624 resolve onChange event value property type error #2653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef6aef1
fix(pie-checkbox-group): resolve onChange event value property type e…
AZEEMAZAM1 Jan 3, 2026
054d1d4
Add changeset for pie-checkbox-group fix
AZEEMAZAM1 Jan 6, 2026
73278b9
Merge branch 'main' into dsw-123-checkbox-onchange-fix
siggerzz Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-checkbox-group-onchange.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@justeattakeaway/pie-checkbox-group": patch
---

[Fixed] - onChange event value property type error
3 changes: 2 additions & 1 deletion packages/components/pie-checkbox-group/src/defs-react.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type React from 'react';

export type ReactBaseType = React.FieldsetHTMLAttributes<HTMLFieldSetElement>
// Omit event types to avoid conflicting with PieCheckboxGroup's type definition
export type ReactBaseType = Omit<React.FieldsetsHTMLAttributes<HTMLFieldSetElement>, 'onChange'>
Loading