Release v1.13.0#3561
Merged
Merged
Conversation
dosubot
Bot
added
the
size:M
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (81)
📝 WalkthroughWalkthroughThis PR performs a comprehensive version bump across the entire repository, updating version numbers from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 1.12.40 to 1.13.0 across a wide range of files, including build configurations for Android, iOS, HarmonyOS, Rust, Node.js, and Python, as well as documentation and example projects. The changes also include updating the changelog, version codes, and Git metadata in the C++ source. Feedback was provided regarding the new-release.sh script, suggesting the removal of unnecessary backslash escapes for dots in the replacement version string to improve clarity and portability across different sed implementations.
| old_version="1\.12\.39" | ||
| new_version="1\.12\.40" | ||
| old_version="1\.12\.40" | ||
| new_version="1\.13\.0" |
There was a problem hiding this comment.
In sed replacement strings, dots do not need to be escaped. Escaping them is unnecessary and can lead to literal backslashes being inserted into files depending on the sed implementation used (e.g., some versions of sed might treat \. as a literal backslash followed by a dot). It is better to keep the replacement string clean while keeping the escapes in the search pattern (regex) defined in old_version.
Suggested change
| new_version="1\.13\.0" | |
| new_version="1.13.0" |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit