Repository navigation
ci: authenticate with the App's client ID - #10
Merged
Merged
Conversation
create-github-app-token v3 deprecates the app-id input in favour of client-id. Both the release job and bump-tap.yml now pass the App's client ID from a new TAP_APP_CLIENT_ID secret. Also drop bump-tap.yml's manual revoke step: the action revokes its token in a post step by default, so the manual DELETE ran against an already-revoked token.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-github-app-tokenv3 deprecates theapp-idinput in favour ofclient-id. Both places that mint a token, thereleasejob inci.ymlandbump-tap.yml, now pass the App's client ID from a newTAP_APP_CLIENT_IDsecret.Also removes the manual "Revoke the token" step from
bump-tap.yml. The action revokes its token in a post step by default (skip-token-revokeis false), so the manualDELETE /installation/tokenran against a token that was about to be revoked anyway.Verification
workflow_dispatchofbump-tap.ymlfrom this branch withtag=v2.0.1exercises the new minting path. That version is already pinned, so it opens no PR.releasejob mints its own token the same way. "Allowed to push to the Git repository" in its log proves it. Aci:title releases nothing.Once both paths are proven,
TAP_APP_IDcan be deleted.