Repository navigation
ci: drop the duplicate test step and the no-op concurrency flag, group Swift bumps - #16
Merged
Merged
Conversation
…p Swift bumps Warnings are errors in debug builds through Package.swift, so CI runs the same two commands the README lists. The schema contract step re-ran tests the full run already covers, and strict-concurrency=complete is the default in Swift 6 language mode. Dependabot opens one grouped PR for minor and patch Swift bumps. Claude-Session: https://claude.ai/code/session_01XR9wyQPT1iM8wzP9hvmYRu
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth of the refactoring series: CI runs exactly the commands the README lists, and Swift dependency bumps arrive as one PR a week.
Change
Package.swift. All four targets get.treatAllWarnings(as: .error, .when(configuration: .debug)). CI'sswift testbuilds debug, so it is now the warnings gate.-Xswiftcflags are gone from CI.-warnings-as-errorsalso reached the dependencies. On a newer local toolchain it fails the build on a swift-sdk warning, so the documented CI command could not be run locally.-strict-concurrency=completeis already the default in Swift 6 language mode.Schema contract testsstep is deleted. It re-ran a suite the full test step already covers. The build step is renamedBuild (release).swiftgroup, instead of grouping only the two Apple packages. Majors still arrive one by one.swift build -c releaseandswift test, and nothing else.The plan had rejected a manifest warnings setting because Homebrew builds from source. The debug condition removes that risk. These behaviours were checked with a scratch package on Swift 6.4:
Verification
swift build -c releaseis clean.swift test: 66 library tests and 98 server tests pass, now with warnings as errors.Mutation record
letin a library source fileswift buildfails witherror: initialization of immutable value 'unused' was never used.swift build -c releasereports the same diagnostic as a warning and completes.letin a test-target fileswift testfails to compile with the same error.var leaked: [String] = []in the libraryswift build -c releasefails withvar 'leaked' is not concurrency-safe because it is nonisolated global shared mutable state. Complete checking needs no flag.All reverted before commit.
Release impact
None. CI, Dependabot, README, and a debug-only build setting. Release builds and the binary are unchanged.
https://claude.ai/code/session_01XR9wyQPT1iM8wzP9hvmYRu