Add retry failure policy support - #140
Merged
Merged
Conversation
1 task
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
add-retry-support
branch
from
July 21, 2026 23:38
a3449fc to
12b1320
Compare
mgfritch
approved these changes
Jul 22, 2026
matttrach
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry failure policy blindly runs a
helm upgradeand exits successfully, relying on helm-controller to recreate the job with new expected release version if the release is still failed or the current release's hash label does not match. Other failures prior to the upgrade command executing are handled by the kubelet restarting the container.Exiting unsuccessfully after creating a failed release would simply defer the error until the next time the container is restarted, at which point the expected release version will not match. Better to handle it at the helm-controller level.