Skip to content

Add retry failure policy support #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandond merged 1 commit into from
Jul 22, 2026
Merged

Add retry failure policy support #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 32 additions & 17 deletions entry
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ helm_update() {
exit
fi

check_revision ${REVISION}
check_revision ${REVISION}

echo "Uninstalling ${HELM} chart" >> ${TERM_LOG}
${HELM} uninstall ${NAME} --namespace ${TARGET_NAMESPACE} --wait || true
Expand All @@ -30,7 +30,7 @@ helm_update() {
exit
fi

check_revision ${REVISION}
check_revision ${REVISION}

# If a previous helm operation was interrupted unexpectedly or release state is corrupted, set it to failed.
if [[ "${STATUS}" =~ ^(pending-install|pending-upgrade|pending-rollback|superseded|uninstalling)$ ]]; then
Expand Down Expand Up @@ -64,21 +64,36 @@ helm_update() {
exit
fi

# The chart is in a bad state; try uninstalling it first
if [[ "${STATUS}" =~ ^(deleted|failed|null|unknown)$ ]]; then
if [[ "${FAILURE_POLICY:-reinstall}" == "reinstall" ]]; then
case "${FAILURE_POLICY:-reinstall}" in
"abort")
# The chart is in a bad state; try uninstalling it first
echo "Release status is '${STATUS}' and failure policy is '${FAILURE_POLICY}'; waiting for operator intervention" >> ${TERM_LOG}
echo "Release status is '${STATUS}' and failure policy is '${FAILURE_POLICY}'; waiting for operator intervention"
exit 1
;;
"reinstall")
echo "Uninstalling ${STATUS} ${HELM} chart" >> ${TERM_LOG}
${HELM} uninstall ${NAME} --namespace ${TARGET_NAMESPACE} --wait
echo Deleted
# Try installing now that we've uninstalled
echo "Installing ${HELM} chart" >> ${TERM_LOG}
${HELM} "$@" ${NAME_ARG} ${NAME} "${CHART}" ${CA_FILE_ARG} ${INSECURE_TLS_ARG} ${PLAIN_HTTP_ARG} ${TIMEOUT_ARG} ${LABELS_ARG} ${VALUES}
exit
else
echo "Release status is '${STATUS}' and failure policy is '${FAILURE_POLICY}', not 'reinstall'; waiting for operator intervention" >> ${TERM_LOG}
echo "Release status is '${STATUS}' and failure policy is '${FAILURE_POLICY}', not 'reinstall'; waiting for operator intervention"
;;
"retry")
# Try upgrading again, in hope that the failure has been resolved
echo "Upgrading ${NAME} from failed state" >> ${TERM_LOG}
shift 1
${HELM} upgrade "$@" ${NAME} "${CHART}" ${CA_FILE_ARG} ${INSECURE_TLS_ARG} ${PLAIN_HTTP_ARG} ${TIMEOUT_ARG} ${LABELS_ARG} ${VALUES}
exit 0
;;
*)
echo "Unknown failure policy '${FAILURE_POLICY}'" >> ${TERM_LOG}
echo "Unknown failure policy '${FAILURE_POLICY}'"
exit 1
fi
;;
esac
fi

# No special status handling necessary, do whatever we were asked to do
Expand Down Expand Up @@ -130,12 +145,12 @@ helm_content_decode() {
}

check_revision() {
REVISION="$1"
if [[ -n "${EXPECTED_RELEASE_REVISION}" ]] && [[ "${EXPECTED_RELEASE_REVISION}" != "${REVISION}" ]]; then
echo "Current release revision ${REVISION} does not match expected revision ${EXPECTED_RELEASE_REVISION}" >> ${TERM_LOG}
echo "Current release revision ${REVISION} does not match expected revision ${EXPECTED_RELEASE_REVISION}"
exit
fi
REVISION="$1"
if [[ -n "${EXPECTED_RELEASE_REVISION}" ]] && [[ "${EXPECTED_RELEASE_REVISION}" != "${REVISION}" ]]; then
echo "Current release revision ${REVISION} does not match expected revision ${EXPECTED_RELEASE_REVISION}" >> ${TERM_LOG}
echo "Current release revision ${REVISION} does not match expected revision ${EXPECTED_RELEASE_REVISION}"
exit
fi
}

# do not interrupt helm while it is running, or it will likely leave the release in a pending state
Expand Down Expand Up @@ -192,19 +207,19 @@ if [[ -f "/tmp/ca-file.pem" ]]; then
fi

if [[ "${INSECURE_SKIP_TLS_VERIFY}" == "true" ]]; then
INSECURE_TLS_ARG="--insecure-skip-tls-verify"
INSECURE_TLS_ARG="--insecure-skip-tls-verify"
fi

if [[ "${PLAIN_HTTP}" == "true" ]]; then
PLAIN_HTTP_ARG="--plain-http"
PLAIN_HTTP_ARG="--plain-http"
fi

if [[ -n "${TIMEOUT}" ]]; then
TIMEOUT_ARG="--timeout ${TIMEOUT}"
fi

if [[ -n "${CONFIG_HASH}" ]]; then
LABELS_ARG="--labels ${CONFIG_HASH_KEY}=${CONFIG_HASH}"
LABELS_ARG="--labels ${CONFIG_HASH_KEY}=${CONFIG_HASH}"
fi

helm_content_decode
Expand Down