Skip to content

Comments

[release-0.49] tests: Fix timing race in legacy ConfigMap upgrade test#560

Merged
kubevirt-bot merged 1 commit intok8snetworkplumbingwg:release-0.49from
kubevirt-bot:cherry-pick-559-to-release-0.49
Aug 7, 2025
Merged

[release-0.49] tests: Fix timing race in legacy ConfigMap upgrade test#560
kubevirt-bot merged 1 commit intok8snetworkplumbingwg:release-0.49from
kubevirt-bot:cherry-pick-559-to-release-0.49

Conversation

@kubevirt-bot
Copy link
Collaborator

This is an automated cherry-pick of #559

/assign RamLavi

NONE

The test for legacy ConfigMap migration was failing due to a timing race
condition. The MAC entry was becoming stale too quickly (after 1 minute)
before the test could verify the "occupied" state.

Changed the stale timeout from 1 minute to 3 minutes in
simulateSoonToBeStaleEntryInConfigMap() to give the test sufficient
time.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
@RamLavi
Copy link
Member

RamLavi commented Aug 7, 2025

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RamLavi
Copy link
Member

RamLavi commented Aug 7, 2025

/cherry-pick release-0.47

@kubevirt-bot
Copy link
Collaborator Author

@RamLavi: once the present PR merges, I will cherry-pick it on top of release-0.47 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit fcd7e24 into k8snetworkplumbingwg:release-0.49 Aug 7, 2025
5 checks passed
@kubevirt-bot
Copy link
Collaborator Author

@RamLavi: new pull request created: #561

Details

In response to this:

/cherry-pick release-0.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants