tests: Fix timing race in legacy ConfigMap upgrade test#559
tests: Fix timing race in legacy ConfigMap upgrade test#559kubevirt-bot merged 1 commit intok8snetworkplumbingwg:mainfrom
Conversation
The test for legacy ConfigMap migration was failing due to a timing race condition. The MAC entry was becoming stale too quickly (after 1 minute) before the test could verify the "occupied" state. Changed the stale timeout from 1 minute to 3 minutes in simulateSoonToBeStaleEntryInConfigMap() to give the test sufficient time. Signed-off-by: Ram Lavi <ralavi@redhat.com>
|
/retest |
|
Thanks /lgtm |
|
/approve /cherry-pick release-0.49 |
|
@RamLavi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@RamLavi: new pull request created: #560 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Following [0] the e2e takes longer, making it timeout on some CI cases. Increasing the timeout to 90m. [0] k8snetworkplumbingwg#559 Signed-off-by: Ram Lavi <ralavi@redhat.com>
Following [0] the e2e takes longer, making it timeout on some CI cases. Increasing the timeout to 90m. [0] k8snetworkplumbingwg#559 Signed-off-by: Ram Lavi <ralavi@redhat.com>
Following [0] the e2e takes longer, making it timeout on some CI cases. Increasing the timeout to 90m. [0] #559 Signed-off-by: Ram Lavi <ralavi@redhat.com> Co-authored-by: Ram Lavi <ralavi@redhat.com>
Following [0] the e2e takes longer, making it timeout on some CI cases. Increasing the timeout to 90m. [0] k8snetworkplumbingwg#559 Signed-off-by: Ram Lavi <ralavi@redhat.com>
Following [0] the e2e takes longer, making it timeout on some CI cases. Increasing the timeout to 90m. [0] #559 Signed-off-by: Ram Lavi <ralavi@redhat.com> Co-authored-by: Ram Lavi <ralavi@redhat.com>
3 participants
What this PR does / why we need it:
This PR is fixing a test flake. The test for legacy ConfigMap migration was failing due to a timing race condition. The MAC entry was becoming stale too quickly (after 1 minute) before the test could verify the "occupied" state.
Changed the stale timeout from 1 minute to 3 minutes in simulateSoonToBeStaleEntryInConfigMap() to give the test sufficient time.
Special notes for your reviewer:
Fix #558
Release note: