Skip to content

go: Bump to go 1.25.5 #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oshoval wants to merge 1 commit into
base: main
Choose a base branch
from
Open

go: Bump to go 1.25.5 #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/k8snetworkplumbingwg/ovs-cni

go 1.25.3
go 1.25.5
Copy link

@gemini-code-assist gemini-code-assist bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The update to Go version 1.25.5 is intended to fix a security vulnerability (GO-2025-4155). However, 1.25.5 is not a released Go version and appears to be a typo, which will cause build failures. More critically, the project's build process is currently configured in a way that makes this fix non-deterministic. The hack/install-go.sh script (called by the Makefile) dynamically fetches the latest Go version from the internet (https://go.dev/dl/?mode=json) instead of respecting the version specified here in go.mod. This means that the actual Go toolchain used to build the project may not match the version declared in this file. If the external API returns an older version, the resulting binaries will remain vulnerable to GO-2025-4155. To remediate this, correct the Go version to a released, secure version (e.g., 1.22.5) and update hack/install-go.sh to extract the Go version directly from go.mod using a command like grep "^go " go.mod | cut -d' ' -f2.

Suggested change
go 1.25.5
go 1.22.5


require (
dario.cat/mergo v1.0.2
Expand Down