Skip to content

go: Bump to go 1.25.5#434

Open
oshoval wants to merge 1 commit intok8snetworkplumbingwg:mainfrom
oshoval:bg
Open

go: Bump to go 1.25.5#434
oshoval wants to merge 1 commit intok8snetworkplumbingwg:mainfrom
oshoval:bg

Conversation

@oshoval
Copy link
Member

@oshoval oshoval commented Feb 26, 2026

What this PR does / why we need it:
Fixes https://pkg.go.dev/vuln/GO-2025-4155

Special notes for your reviewer:

Release note:

None

Fixes https://pkg.go.dev/vuln/GO-2025-4155

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 26, 2026
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oshoval
Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @oshoval, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical dependency update, elevating the project's Go language version to 1.25.5. This ensures the integration of the latest stability improvements and security patches, directly mitigating a known vulnerability to enhance the overall robustness and security posture of the application.

Highlights

  • Go Version Update: The Go language version required by the project has been updated from 1.25.3 to 1.25.5.
  • Security Vulnerability Fix: This update specifically addresses and fixes the security vulnerability identified as GO-2025-4155.
Changelog
  • go.mod
    • Updated the required Go version to 1.25.5.
Activity
  • No review activity or comments have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@oshoval
Copy link
Member Author

oshoval commented Feb 26, 2026

cc @SchSeba @phoracek

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update the Go version in go.mod to address a security vulnerability (GO-2025-4155). However, the specified version 1.25.5 appears to be a typo as Go 1.25 is not a released version, which will cause build failures. More critically, the current build infrastructure, particularly hack/install-go.sh, does not enforce the go.mod version, potentially leading to the project being built with a vulnerable toolchain. Additionally, the installation script and Makefile contain unquoted variables that could introduce command injection vulnerabilities, though these were not introduced in this PR.

module github.com/k8snetworkplumbingwg/ovs-cni

go 1.25.3
go 1.25.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The update to Go version 1.25.5 is intended to fix a security vulnerability (GO-2025-4155). However, 1.25.5 is not a released Go version and appears to be a typo, which will cause build failures. More critically, the project's build process is currently configured in a way that makes this fix non-deterministic. The hack/install-go.sh script (called by the Makefile) dynamically fetches the latest Go version from the internet (https://go.dev/dl/?mode=json) instead of respecting the version specified here in go.mod. This means that the actual Go toolchain used to build the project may not match the version declared in this file. If the external API returns an older version, the resulting binaries will remain vulnerable to GO-2025-4155. To remediate this, correct the Go version to a released, secure version (e.g., 1.22.5) and update hack/install-go.sh to extract the Go version directly from go.mod using a command like grep "^go " go.mod | cut -d' ' -f2.

Suggested change
go 1.25.5
go 1.22.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants