Revert "Merge pull request #170 from gtannous-spec/nodeptpdevice-feat"

[gtannous-spec]

This reverts commit f53b758, reversing changes made to 2bf6cc1.

This changes were reverted because it was causing vendor issues in the linuxptp-daemon PR#152
Once fixed there, I will push a new PR to update the api again.

[gemini-code-assist]

Summary of Changes

Hello @gtannous-spec, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete revert of a previous merge, effectively undoing changes related to the NodePtpDevice API and its associated Custom Resource Definition. The primary impact is the restoration of the HardwareInfo structure to its previous definition, which includes removing certain PCI identifiers and reintroducing network link status and specific VPD fields. Additionally, the operator's manifest creation timestamp has been reset to its prior value.

Highlights

• API Reversion: Undid modifications to the NodePtpDevice API's HardwareInfo struct, removing newly added PCI fields (VendorID, DeviceID, SubsystemVendorID, SubsystemDeviceID) and restoring previously removed network link status (LinkStatus, LinkSpeed, FEC) and specific VPD fields (VPDIdentifierString, VPDVendorSpecific1, VPDVendorSpecific2).
• CRD Schema Rollback: Rolled back the Custom Resource Definition (CRD) schema for NodePtpDevice across multiple manifest files to align with the reverted API struct changes, ensuring consistency in the resource definition.
• Manifest Timestamp Revert: Reverted the createdAt timestamp in the operator's ClusterServiceVersion manifests to an earlier date.

Changelog

• api/v1/nodeptpdevice_types.go
  • Reverted changes to the HardwareInfo struct, removing PCI vendor/device IDs and restoring link status and specific VPD fields.
• bundle/manifests/ptp-operator.clusterserviceversion.yaml
  • Reverted the createdAt timestamp.
• bundle/manifests/ptp.openshift.io_nodeptpdevices.yaml
  • Reverted the CRD schema for NodePtpDevice to remove PCI vendor/device IDs and restore link status and specific VPD fields.
• config/crd/bases/ptp.openshift.io_nodeptpdevices.yaml
  • Reverted the CRD schema for NodePtpDevice to remove PCI vendor/device IDs and restore link status and specific VPD fields.
• manifests/stable/ptp-operator.clusterserviceversion.yaml
  • Reverted the createdAt timestamp.
• manifests/stable/ptp.openshift.io_nodeptpdevices.yaml
  • Reverted the CRD schema for NodePtpDevice to remove PCI vendor/device IDs and restore link status and specific VPD fields.

Activity

• The pull request was created by gtannous-spec to revert a previous commit, specifically 'Merge pull request modified nodeptpdevice status field #170 from gtannous-spec/nodeptpdevice-feat'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous feature that added more detailed hardware information to the NodePtpDevice status. The changes consistently remove the new fields from the HardwareInfo struct in api/v1/nodeptpdevice_types.go and update the corresponding Custom Resource Definitions in the various YAML manifest files. The revert appears to be complete and correct, with no lingering artifacts from the reverted feature in the changed files.