Skip to content

Revert "Merge pull request #170 from gtannous-spec/nodeptpdevice-feat" #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gtannous-spec merged 1 commit into from
Feb 17, 2026
Merged

Revert "Merge pull request #170 from gtannous-spec/nodeptpdevice-feat" #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 17 additions & 28 deletions api/v1/nodeptpdevice_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,42 +56,40 @@ type PtpDevice struct {

// HardwareInfo contains detailed hardware identification and characteristics of a PTP device
type HardwareInfo struct {
// PCI Information
// PCI Information - Device location and identification on the PCI bus

// PCIAddress is the PCI bus address (e.g., "0000:01:00.0")
// +optional
PCIAddress string `json:"pciAddress,omitempty"`

// Firmware and Driver Information

// FirmwareVersion is the version of the device firmware
// VendorID is the PCI vendor identifier (e.g., "8086" for Intel)
// +optional
FirmwareVersion string `json:"firmwareVersion,omitempty"`
VendorID string `json:"vendorID,omitempty"`

// DriverVersion is the version of the kernel driver in use
// DeviceID is the PCI device identifier
// +optional
DriverVersion string `json:"driverVersion,omitempty"`
DeviceID string `json:"deviceID,omitempty"`

// Link Status Information
// SubsystemVendorID is the PCI subsystem vendor identifier
// +optional
SubsystemVendorID string `json:"subsystemVendorID,omitempty"`

// LinkStatus indicates whether the link is up ("up") or down ("down")
// SubsystemDeviceID is the PCI subsystem device identifier
// +optional
LinkStatus string `json:"linkStatus,omitempty"`
SubsystemDeviceID string `json:"subsystemDeviceID,omitempty"`

// Firmware and Driver Information

// LinkSpeed is the negotiated link speed (e.g., "25000Mb/s", "Unknown!")
// FirmwareVersion is the version of the device firmware
// +optional
LinkSpeed string `json:"linkSpeed,omitempty"`
FirmwareVersion string `json:"firmwareVersion,omitempty"`

// FEC is the Forward Error Correction mode in use (e.g., "RS", "BaseR", "Off", "None")
// DriverVersion is the version of the kernel driver in use
// +optional
FEC string `json:"fec,omitempty"`
DriverVersion string `json:"driverVersion,omitempty"`

// VPD (Vital Product Data) - Manufacturing and product information

// VPDIdentifierString is the device identifier string from VPD
// +optional
VPDIdentifierString string `json:"vpdIdentifierString,omitempty"`

// VPDPartNumber is the manufacturer's part number from VPD
// +optional
VPDPartNumber string `json:"vpdPartNumber,omitempty"`
Expand All @@ -104,18 +102,9 @@ type HardwareInfo struct {
// +optional
VPDManufacturerID string `json:"vpdManufacturerID,omitempty"`

// VPDProductName is the product name from VPD (V0 field)
// VPDProductName is the product name from VPD
// +optional
VPDProductName string `json:"vpdProductName,omitempty"`

// VPDVendorSpecific1 is vendor-specific data from VPD (V1 field)
// Often contains detailed product identification useful for hardware fingerprinting
// +optional
VPDVendorSpecific1 string `json:"vpdVendorSpecific1,omitempty"`

// VPDVendorSpecific2 is vendor-specific data from VPD (V2 field)
// +optional
VPDVendorSpecific2 string `json:"vpdVendorSpecific2,omitempty"`
}

type HwConfig struct {
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/ptp-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ metadata:
categories: Networking
certified: "false"
containerImage: quay.io/openshift/origin-ptp-operator:4.22
createdAt: "2026-02-15T21:41:01Z"
createdAt: "2026-01-20T12:52:18Z"
description: This software enables configuration of Precision Time Protocol(PTP)
on Kubernetes. It detects hardware capable PTP devices on each node, and configures
linuxptp processes such as ptp4l, phc2sys and timemaster.
Expand Down
39 changes: 14 additions & 25 deletions bundle/manifests/ptp.openshift.io_nodeptpdevices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,31 @@ spec:
description: HardwareInfo contains detailed hardware identification
information for the device.
properties:
deviceID:
description: DeviceID is the PCI device identifier
type: string
driverVersion:
description: DriverVersion is the version of the kernel
driver in use
type: string
fec:
description: FEC is the Forward Error Correction mode in
use (e.g., "RS", "BaseR", "Off", "None")
type: string
firmwareVersion:
description: FirmwareVersion is the version of the device
firmware
type: string
linkSpeed:
description: LinkSpeed is the negotiated link speed (e.g.,
"25000Mb/s", "Unknown!")
type: string
linkStatus:
description: LinkStatus indicates whether the link is up
("up") or down ("down")
type: string
pciAddress:
description: PCIAddress is the PCI bus address (e.g., "0000:01:00.0")
type: string
vpdIdentifierString:
description: VPDIdentifierString is the device identifier
string from VPD
subsystemDeviceID:
description: SubsystemDeviceID is the PCI subsystem device
identifier
type: string
subsystemVendorID:
description: SubsystemVendorID is the PCI subsystem vendor
identifier
type: string
vendorID:
description: VendorID is the PCI vendor identifier (e.g.,
"8086" for Intel)
type: string
vpdManufacturerID:
description: VPDManufacturerID is the manufacturer identifier
Expand All @@ -93,21 +92,11 @@ spec:
type: string
vpdProductName:
description: VPDProductName is the product name from VPD
(V0 field)
type: string
vpdSerialNumber:
description: VPDSerialNumber is the unique serial number
from VPD
type: string
vpdVendorSpecific1:
description: |-
VPDVendorSpecific1 is vendor-specific data from VPD (V1 field)
Often contains detailed product identification useful for hardware fingerprinting
type: string
vpdVendorSpecific2:
description: VPDVendorSpecific2 is vendor-specific data
from VPD (V2 field)
type: string
type: object
name:
description: |-
Expand Down
39 changes: 14 additions & 25 deletions config/crd/bases/ptp.openshift.io_nodeptpdevices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,31 @@ spec:
description: HardwareInfo contains detailed hardware identification
information for the device.
properties:
deviceID:
description: DeviceID is the PCI device identifier
type: string
driverVersion:
description: DriverVersion is the version of the kernel
driver in use
type: string
fec:
description: FEC is the Forward Error Correction mode in
use (e.g., "RS", "BaseR", "Off", "None")
type: string
firmwareVersion:
description: FirmwareVersion is the version of the device
firmware
type: string
linkSpeed:
description: LinkSpeed is the negotiated link speed (e.g.,
"25000Mb/s", "Unknown!")
type: string
linkStatus:
description: LinkStatus indicates whether the link is up
("up") or down ("down")
type: string
pciAddress:
description: PCIAddress is the PCI bus address (e.g., "0000:01:00.0")
type: string
vpdIdentifierString:
description: VPDIdentifierString is the device identifier
string from VPD
subsystemDeviceID:
description: SubsystemDeviceID is the PCI subsystem device
identifier
type: string
subsystemVendorID:
description: SubsystemVendorID is the PCI subsystem vendor
identifier
type: string
vendorID:
description: VendorID is the PCI vendor identifier (e.g.,
"8086" for Intel)
type: string
vpdManufacturerID:
description: VPDManufacturerID is the manufacturer identifier
Expand All @@ -93,21 +92,11 @@ spec:
type: string
vpdProductName:
description: VPDProductName is the product name from VPD
(V0 field)
type: string
vpdSerialNumber:
description: VPDSerialNumber is the unique serial number
from VPD
type: string
vpdVendorSpecific1:
description: |-
VPDVendorSpecific1 is vendor-specific data from VPD (V1 field)
Often contains detailed product identification useful for hardware fingerprinting
type: string
vpdVendorSpecific2:
description: VPDVendorSpecific2 is vendor-specific data
from VPD (V2 field)
type: string
type: object
name:
description: |-
Expand Down
2 changes: 1 addition & 1 deletion manifests/stable/ptp-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ metadata:
categories: Networking
certified: "false"
containerImage: quay.io/openshift/origin-ptp-operator:4.22
createdAt: "2026-02-15T21:41:01Z"
createdAt: "2026-01-20T12:52:18Z"
description: This software enables configuration of Precision Time Protocol(PTP)
on Kubernetes. It detects hardware capable PTP devices on each node, and configures
linuxptp processes such as ptp4l, phc2sys and timemaster.
Expand Down
39 changes: 14 additions & 25 deletions manifests/stable/ptp.openshift.io_nodeptpdevices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,31 @@ spec:
description: HardwareInfo contains detailed hardware identification
information for the device.
properties:
deviceID:
description: DeviceID is the PCI device identifier
type: string
driverVersion:
description: DriverVersion is the version of the kernel
driver in use
type: string
fec:
description: FEC is the Forward Error Correction mode in
use (e.g., "RS", "BaseR", "Off", "None")
type: string
firmwareVersion:
description: FirmwareVersion is the version of the device
firmware
type: string
linkSpeed:
description: LinkSpeed is the negotiated link speed (e.g.,
"25000Mb/s", "Unknown!")
type: string
linkStatus:
description: LinkStatus indicates whether the link is up
("up") or down ("down")
type: string
pciAddress:
description: PCIAddress is the PCI bus address (e.g., "0000:01:00.0")
type: string
vpdIdentifierString:
description: VPDIdentifierString is the device identifier
string from VPD
subsystemDeviceID:
description: SubsystemDeviceID is the PCI subsystem device
identifier
type: string
subsystemVendorID:
description: SubsystemVendorID is the PCI subsystem vendor
identifier
type: string
vendorID:
description: VendorID is the PCI vendor identifier (e.g.,
"8086" for Intel)
type: string
vpdManufacturerID:
description: VPDManufacturerID is the manufacturer identifier
Expand All @@ -93,21 +92,11 @@ spec:
type: string
vpdProductName:
description: VPDProductName is the product name from VPD
(V0 field)
type: string
vpdSerialNumber:
description: VPDSerialNumber is the unique serial number
from VPD
type: string
vpdVendorSpecific1:
description: |-
VPDVendorSpecific1 is vendor-specific data from VPD (V1 field)
Often contains detailed product identification useful for hardware fingerprinting
type: string
vpdVendorSpecific2:
description: VPDVendorSpecific2 is vendor-specific data
from VPD (V2 field)
type: string
type: object
name:
description: |-
Expand Down
Loading