🐛 Fixes workflow scripts#558
Open
adilGhaffarDev wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Open
🐛 Fixes workflow scripts#558adilGhaffarDev wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
adilGhaffarDev wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Conversation
Member
|
Can you please merge this branch in your repository |
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
87eaaa3 to
2db2d7d
Compare
Collaborator
Pull Request Test Coverage Report for Build 9094134752Details
💛 - Coveralls |
Contributor
Author
I added a fix and tried it on my fork, The image pushes passes (skipped) but push-manifest fails, I need to check that. https://github.com/adilGhaffarDev/sriov-network-device-plugin/actions/runs/9094211979 |
Collaborator
|
Hi @adilGhaffarDev any update on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes: #540
it was breaking image push with following error:
This PR has moved the
iffurther in the tree whereenvis accessible.