Design proposal for the platform-orchestrator-abstraction #917

SchSeba · 2025-07-21T11:30:32Z

No description provided.

github-actions · 2025-07-21T11:30:39Z

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2025-07-21T11:42:07Z

Pull Request Test Coverage Report for Build 19530595480

Details

0 of 0 changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 62.13%

Files with Coverage Reduction	New Missed Lines	%
pkg/daemon/daemon.go	2	45.66%
controllers/helper.go	3	70.23%

Totals
Change from base Build 19406283464:	-0.03%
Covered Lines:	8769
Relevant Lines:	14114

💛 - Coveralls

SchSeba · 2025-09-08T10:33:33Z

Hi @zeeke @e0ne @adrianchiris please help move this one forward it's a critical feature I would like to get in as soon as possible.

Thanks!

adrianchiris · 2025-09-10T13:26:09Z

doc/design/platform-orchestrator-abstraction.md

+- **Comprehensive Testing**: Includes extensive unit tests with mocked HTTP calls
+- **Error Handling**: Robust error handling for metadata service failures
+
+This approach makes the SR-IOV Network Operator truly platform-agnostic while maintaining clean, maintainable code. 


nit: not really related to design doc

adrianchiris · 2025-09-10T13:30:07Z

doc/design/platform-orchestrator-abstraction.md

+
+### Use Cases
+
+1. **Multi-Platform Support**: Enable the operator to run efficiently on different infrastructure platforms (bare metal, OpenStack, AWS,Oracle, etc.) with platform-specific optimizations


i think this is the only use-case here no ?

I left both the platform and the orchestration as use-cases

adrianchiris · 2025-09-10T13:33:37Z

doc/design/platform-orchestrator-abstraction.md

+### Goals
+
+* Create a clean abstraction layer that separates platform-specific logic from orchestrator-specific logic
+* Implement support for bare metal and OpenStack platforms


this is already implemented, you mean re-implement support for these platforms using the defined abstraction ?

yep, I changed it

adrianchiris · 2025-09-10T13:34:35Z

doc/design/platform-orchestrator-abstraction.md

+
+* Create a clean abstraction layer that separates platform-specific logic from orchestrator-specific logic
+* Implement support for bare metal and OpenStack platforms
+* Implement support for Kubernetes and OpenShift orchestrators


same as above

adrianchiris · 2025-09-10T13:37:45Z

doc/design/platform-orchestrator-abstraction.md

+### Non-Goals
+
+* Support all possible infrastructure platforms in the initial implementation
+* Change existing API structures or user-facing interfaces


what does it mean ?

no CRD changes neeeded. I updated to make it more clear.

adrianchiris · 2025-09-10T15:06:13Z

doc/design/platform-orchestrator-abstraction.md

+    ClusterType() consts.ClusterType
+    Flavor() consts.ClusterFlavor
+    BeforeDrainNode(context.Context, *corev1.Node) (bool, error)
+    AfterCompleteDrainNode(context.Context, *corev1.Node) (bool, error)


nit: to be symmetric with BeforeDrainNode lets use AfterDrainNode

the problem with AfterDrainNode that it shound like after the operator finish to drain a node.

but that case is for after the operator finish to release a node from a drain(uncordon)

I changed the function names let me know what you think about the new name

doc/design/platform-orchestrator-abstraction.md

adrianchiris · 2025-09-10T15:10:55Z

doc/design/platform-orchestrator-abstraction.md

+
+### Upgrade & Downgrade considerations
+
+The abstraction layer is designed to be backward compatible. Existing configurations and behaviors are preserved, with the abstraction layer providing the same functionality through the new interface structure.


first sentence is irrelevant IMO.

adrianchiris · 2025-09-10T15:14:34Z

doc/design/platform-orchestrator-abstraction.md

+
+#### Factory Pattern
+
+Both platform and orchestrator use factory patterns for instantiation:


facilitating easy extentions for new implementations

adrianchiris · 2025-09-10T15:18:22Z

doc/design/platform-orchestrator-abstraction.md

+```golang
+type Interface interface {
+    Init() error
+    GetHostHelpers() helper.HostHelpersInterface


do you have a usecase for different HostHelpersInterface implementations ?

nope I just use that so the daemon can request the hostHelpers and I don't need to initiate it again and again in the code

SchSeba · 2025-09-25T08:50:51Z

Hi @adrianchiris when you have time please take another look :)

SchSeba · 2025-10-19T09:28:06Z

ping @zeeke @adrianchiris :)

SchSeba · 2025-11-16T10:17:37Z

Hi @e0ne @adrianchiris I updated the design based on the actual implementation we just merged.

please take a look when you have time :)

doc/design/platform-orchestrator-abstraction.md

adrianchiris

lgtm

Signed-off-by: Sebastian Sch <[email protected]>

SchSeba · 2025-11-20T10:54:11Z

Merging this one

SchSeba mentioned this pull request Jul 21, 2025

Create platform and orchestrator packages #902

Merged

adrianchiris reviewed Sep 10, 2025

View reviewed changes

SchSeba force-pushed the platform_and_orchestrator_packages_design branch from adf2583 to d12edf3 Compare September 25, 2025 08:50

e0ne approved these changes Nov 3, 2025

View reviewed changes

SchSeba force-pushed the platform_and_orchestrator_packages_design branch from d12edf3 to c7d1ef9 Compare November 16, 2025 10:15

github-actions bot added the docs label Nov 16, 2025

adrianchiris reviewed Nov 18, 2025

View reviewed changes

doc/design/platform-orchestrator-abstraction.md Outdated Show resolved Hide resolved

adrianchiris approved these changes Nov 18, 2025

View reviewed changes

Design proposal for the platform-orchestrator-abstraction

48fb9f2

Signed-off-by: Sebastian Sch <[email protected]>

SchSeba force-pushed the platform_and_orchestrator_packages_design branch from c7d1ef9 to 48fb9f2 Compare November 20, 2025 08:34

SchSeba merged commit 811252c into k8snetworkplumbingwg:master Nov 20, 2025
12 of 14 checks passed


		### Use Cases

		1. Multi-Platform Support: Enable the operator to run efficiently on different infrastructure platforms (bare metal, OpenStack, AWS,Oracle, etc.) with platform-specific optimizations


		### Upgrade & Downgrade considerations

		The abstraction layer is designed to be backward compatible. Existing configurations and behaviors are preserved, with the abstraction layer providing the same functionality through the new interface structure.


		#### Factory Pattern

		Both platform and orchestrator use factory patterns for instantiation:

Design proposal for the platform-orchestrator-abstraction #917

Design proposal for the platform-orchestrator-abstraction #917

Uh oh!

Conversation

SchSeba commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

coveralls commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 19530595480

Details

💛 - Coveralls

Uh oh!

SchSeba commented Sep 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SchSeba Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SchSeba commented Sep 25, 2025

Uh oh!

SchSeba commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SchSeba commented Nov 16, 2025

Uh oh!

Uh oh!

adrianchiris left a comment

Choose a reason for hiding this comment

Uh oh!

SchSeba commented Nov 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jul 21, 2025 •

edited

Loading

SchSeba Sep 25, 2025 •

edited

Loading

SchSeba commented Oct 19, 2025 •

edited

Loading