-
Notifications
You must be signed in to change notification settings - Fork 142
Remove duplicate app label from helm chart #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Common labels | ||
| */}} | ||
| {{- define "whereabouts.labels" -}} | ||
| app: whereabouts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the app is defined below in selectorLabels, and the value is Chart.name, which is whereabouts-chart. I'm wondering if we should change this to just whereabouts instead. It’s just a cosmetic change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unusual to have "chart" in the app name, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's tackle that in another pr
Pull Request Test Coverage Report for Build 14209089615Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mlguerrero12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks. Can we get a release for this fix? Version |
|
@dhess, done, v0.9.1 |
What this PR does / why we need it:
Only one
applabel should be set on kubernetes resources. fluxcd will refuse to install the chart with duplicate app labels. This removes a hardcoded app label and leaves the label based on the chart name in place.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #591