Skip to content

Remove duplicate app label from helm chart #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Remove duplicate app label from helm chart #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deployment/whereabouts-chart/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ Create chart name and version as used by the chart label.
Common labels
*/}}
{{- define "whereabouts.labels" -}}
app: whereabouts
Copy link
Collaborator

@mlguerrero12 mlguerrero12 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the app is defined below in selectorLabels, and the value is Chart.name, which is whereabouts-chart. I'm wondering if we should change this to just whereabouts instead. It’s just a cosmetic change.

Copy link
Contributor Author

@cyanidium cyanidium Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unusual to have "chart" in the app name, yes.

Copy link
Collaborator

@mlguerrero12 mlguerrero12 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's tackle that in another pr

helm.sh/chart: {{ include "whereabouts.chart" . }}
{{ include "whereabouts.selectorLabels" . }}
{{- if .Chart.AppVersion }}
Expand Down
Loading