Skip to content

Fix lint issue QF1001 #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix lint issue QF1001 #6297

merged 1 commit into from
Apr 14, 2025

Conversation

seanlaii
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix lint issue - QF1001: could apply De Morgan's law (staticcheck).
For more details: https://staticcheck.dev/docs/checks#QF1001

Which issue(s) this PR fixes:
Part of #6273

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 12, 2025
@karmada-bot karmada-bot requested review from lonelyCZ and Poor12 April 12, 2025 21:02
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (1d25159) to head (d4614ed).

Files with missing lines Patch % Lines
pkg/karmadactl/get/get.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6297      +/-   ##
==========================================
- Coverage   48.06%   48.06%   -0.01%     
==========================================
  Files         678      678              
  Lines       56117    56117              
==========================================
- Hits        26973    26972       -1     
+ Misses      27373    27372       -1     
- Partials     1771     1773       +2     
Flag Coverage Δ
unittests 48.06% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@karmada-bot karmada-bot merged commit 4eb2d27 into karmada-io:master Apr 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants