Adding documentation for resource quota enforcement feature#835
Conversation
karmada-bot
added
the
kind/documentation
karmada-bot
added
the
size/M
|
@mszacillo The CI failed during the Netlify Build phase, and it doesn't seem to be a code issue. Could you resubmit your PR to trigger the CI pipeline again? |
|
Let me take a look, another PR is blocked by this issue. |
|
Sent #836 to resolve the failing test. |
|
@mszacillo #836 gets merged, and this should be good after the rebase. |
|
@RainbowMango Awesome! I just rebased my branch. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for the resource quota enforcement feature for FederatedResourceQuota. It updates the best practices guide with additional sections on ResourceQuota Management and control plane-level quota enforcement, and introduces a new usage example for enforcing overall resource limits.
RainbowMango
left a comment
RainbowMango
left a comment
There was a problem hiding this comment.
Looks great! I like this style, simple、 straightforward enough but has everything important.
Just one comment from Copilot needs to take a look?
Signed-off-by: mszacillo <mszacillo@bloomberg.net>
Just resolved! Thanks again for the review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Part of #6350, adds documentation for the resource quota enforcement feature we had added to the FederatedResourceQuota.