Skip to content

Fixed original markdown link couldn't be resolved issue#836

Merged
karmada-bot merged 1 commit into
karmada-io:mainfrom
RainbowMango:pr_fix_unresolved_link_issue
May 20, 2025
Merged

Fixed original markdown link couldn't be resolved issue#836
karmada-bot merged 1 commit into
karmada-io:mainfrom
RainbowMango:pr_fix_unresolved_link_issue

Conversation

@RainbowMango

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixed the compiling issue found at #835 and #834

5:08:51 AM: [info] [webpackbar] Compiling Client
5:08:51 AM: [info] [webpackbar] Compiling Server
5:12:23 AM: [success] [webpackbar] Client: Compiled with some errors in 3.53m
5:12:23 AM: Error: Docs markdown link couldn't be resolved: (/docs/reference/karmadactl/karmadactl-config.v1alpha1.md) in "/opt/build/repo/docs/installation/install-with-cli.md" for version current
    at Array.forEach (<anonymous>)
5:12:23 AM: Error: Docs markdown link couldn't be resolved: (/docs/reference/karmadactl/karmadactl-config.v1alpha1.md) in "/opt/build/repo/versioned_docs/version-v1.12/installation/install-with-cli.md" for version v1.12
    at Array.forEach (<anonymous>)
5:12:23 AM: Error: Docs markdown link couldn't be resolved: (/docs/reference/karmadactl/karmadactl-config.v1alpha1.md) in "/opt/build/repo/versioned_docs/version-v1.13/installation/install-with-cli.md" for version v1.13
    at Array.forEach (<anonymous>)
5:12:23 AM: [ERROR] Client bundle compiled with errors therefore further build is impossible.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2025
@karmada-bot karmada-bot requested review from Poor12 and Tingtal May 19, 2025 07:56
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2025
@RainbowMango

Copy link
Copy Markdown
Member Author

This unresolvable link was introduced by #690, but I don't know why it becomes unresolvable...

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2025
@zhzhuang-zju

Copy link
Copy Markdown
Contributor

This unresolvable link was introduced by #690, but I don't know why it becomes unresolvable..

After comparing the logs, I found that netlify/build was upgraded from version 32.0.0 to 33.0.0, although I'm not entirely sure about the specific impact of this upgrade. However, one lesson to be learned is that Markdown links in documentation should use relative paths instead of absolute paths.

@RainbowMango

Copy link
Copy Markdown
Member Author

Compile succeeds but timeout.

4:23:31 PM: [INFO] [en] Creating an optimized production build...
4:25:08 PM: [info] [webpackbar] Compiling Client
4:25:08 PM: [info] [webpackbar] Compiling Server
4:28:54 PM: [success] [webpackbar] Client: Compiled successfully in 3.78m
4:31:12 PM: [success] [webpackbar] Server: Compiled successfully in 6.07m
4:31:57 PM: [SUCCESS] Generated static files in "build".
4:31:57 PM: [INFO] [zh] Creating an optimized production build...
4:34:33 PM: [info] [webpackbar] Compiling Client
4:34:33 PM: [info] [webpackbar] Compiling Server
4:38:33 PM: [success] [webpackbar] Client: Compiled successfully in 4.00m
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 3 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 8 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 27 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 11 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 9 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 9 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 11 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 27 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 8 分钟
4:39:59 PM: For locale=zh, a maximum of 1 plural forms are expected (other), but the message contains 2: 阅读需要 1 分钟 | 阅读需要 3 分钟
4:41:08 PM: [success] [webpackbar] Server: Compiled successfully in 6.59m
4:41:27 PM: Failed during stage 'building site': Command did not finish within the time limit
4:41:27 PM: Execution timed out after 18m0.264282756s

@RainbowMango

Copy link
Copy Markdown
Member Author

Sent a support request for increasing the build time limit: https://answers.netlify.com/t/please-increase-build-time-limit/148362

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango force-pushed the pr_fix_unresolved_link_issue branch from 4075370 to 78a4cda Compare May 20, 2025 01:14
@RainbowMango

Copy link
Copy Markdown
Member Author

The timeout has been increased to 1 hour. Let's give it another try.

@RainbowMango

Copy link
Copy Markdown
Member Author

It works.
Build time: 19m 28s. Total deploy time: 19m 28s

@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 20, 2025
@karmada-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit c75e433 into karmada-io:main May 20, 2025
7 checks passed
@RainbowMango RainbowMango deleted the pr_fix_unresolved_link_issue branch May 20, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants