fix: allow message in .destroy

[CarrettaRiccardo]

Currently, aborting throws an error in console because no message was passed to abort, which is inside .destroy method (https://developer.mozilla.org/en-US/docs/Web/API/AbortController/abort#parameters)

Implementation details

Added optional message prop to .destroy() method

In src/wavesurfer.ts

/** Unmount wavesurfer */
 public destroy(message?: string) {
   this.emit('destroy')
   this.abortController?.abort(message)
   this.plugins.forEach((plugin) => plugin.destroy())
   this.subscriptions.forEach((unsubscribe) => unsubscribe())
   this.unsubscribePlayerEvents()
   this.timer.destroy()
   this.renderer.destroy()
   super.destroy()
 }

[Copilot]

Pull request overview

This PR enhances the destroy() method by adding an optional message parameter that gets passed to AbortController.abort(). This allows callers to provide a custom abort reason when destroying the WaveSurfer instance.

Key changes:

• Added optional message?: string parameter to the destroy() method signature
• The message is now forwarded to abortController?.abort(message)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[katspaugh]

Good catch! Do we need to pass a message or can we just hard-code something like "Wavesurfer instance was destroyed"?

[CarrettaRiccardo]

Good catch! Do we need to pass a message or can we just hard-code something like "Wavesurfer instance was destroyed"?

Well, i think hardcoding might be okay too! Just want that console error to not print ;)