Skip to content

fix: allow message in .destroy #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarrettaRiccardo wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix: allow message in .destroy #4247

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1eec65
fix: allow message in .destroy
CarrettaRiccardo Nov 24, 2025
6ecaa93
Add jsdoc to .destroy message prop
CarrettaRiccardo Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wavesurfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,9 +675,9 @@ class WaveSurfer extends Player<WaveSurferEvents> {
}

/** Unmount wavesurfer */
Comment thread
CarrettaRiccardo marked this conversation as resolved.
Outdated
public destroy() {
public destroy(message?: string) {
this.emit('destroy')
this.abortController?.abort()
this.abortController?.abort(message)
this.plugins.forEach((plugin) => plugin.destroy())
this.subscriptions.forEach((unsubscribe) => unsubscribe())
this.unsubscribePlayerEvents()
Expand Down
Loading