Feature: add createASCII method - #54
Merged
kazuhikoarase merged 2 commits intoSep 1, 2018
Merged
Conversation
- Added `createASCII` method that outputs QR code rendered using ASCII blocks. - Added JS development dependency on `mocha` to run new tests for basic GIF and ASCII output.
|
Two problems:
|
Contributor
Author
|
@nayuki thanks for comment. You're right that it's actually Unicode. We can rename the method, e.g., "createUnicode" or call it something else. I was going for reminding about "ASCII drawing", but it looks that i was wrong. Any ideas how to name it better? It returns a string, it's up to the caller to style it with control sequences in terminal, or CSS in web browser. |
Owner
I agree. Thanks a lot! |
Contributor
Author
|
Thanks :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This re-applies ASCII output feature from #6. It does not change existing code, it just adds new method.
I use ASCII output in command line tools/scripts :).
Changes:
createASCIImethod that outputs QR code rendered using ASCII blocks.mochato run new tests for basic GIF and ASCII output.UPDATE: below is a screenshot of how it looks in terminal :).
Regards