Added node.js compatibility, mocha test and patches from other forks#6
Open
Hypermediaisobar-admin wants to merge 16 commits intokazuhikoarase:masterfrom
Open
Added node.js compatibility, mocha test and patches from other forks#6Hypermediaisobar-admin wants to merge 16 commits intokazuhikoarase:masterfrom
Hypermediaisobar-admin wants to merge 16 commits intokazuhikoarase:masterfrom
Conversation
Updating RS_BLOCK_TABLE to support version 11 - 40. Updating make to handle auto version mode (if typeNumber == 0, the qrcode generator will set version according to the length of data).
Support version 11 - 40 (typeNumber) and auto mode
So it uses auto mode and escapes unicode.
Added new `createImage(cellSize, margin)` function, that uses code extracted from `createImgTag()` function. This allows user to call `createImage()` to get raw GIF data (in a form of object, with `bytes`, `width` and `height` properties) or `createImgTag` as before.
…rator Conflicts: js/sample.js
|
Not the maintainer, but I'd suggest removing the reindent (45d0c74), as it makes it impossible to see what the changes are. |
Contributor
|
@marksteward you're absolutely right. I reapplied changes in a new pull request :). |
Contributor
|
@kazuhikoarase please close this, as it was implemented in #54 :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for your work :).
We've added some glue code that allows using qrcode.js in nodejs.
Additionally, we've:
It would be great if you could merge it all into official repo.
Please let us know if anything has to be changed before merge, or if those changes cannot be merged at all for some reason.
Thanks,
Regards