refactor(include): migrate public headers to include/kcenon/container/ convention#440
Merged
Merged
Conversation
…/ convention Move all public headers from core/ to include/kcenon/container/ to match the kcenon ecosystem convention used by all other systems (thread_system, common_system, etc.). Original core/ headers are replaced with forwarding headers for full backward compatibility. Changes: - Copy 23 public headers to include/kcenon/container/ (with subdirs container/, serializers/, optimizations/) - Replace core/ originals with forwarding headers (#include <kcenon/...>) - Add include/ to BUILD_INTERFACE include paths in CMakeLists.txt - Add install rule for include/kcenon/ directory - Update module target include directories Backward compatibility: All existing #include paths continue to work via the forwarding headers in core/. No consumer code changes required. Closes #439
Contributor
Performance Benchmark ReportSummary
✅ Status: No significant performance regressions detected. |
kcenon
added a commit
that referenced
this pull request
Mar 19, 2026
After PR #440 migrated headers to include/kcenon/container/, two directories were missing from the cmake install rules: - include/container/ forwarding headers (for #include <container/...>) - messaging/ directory (message_container.h) This caused downstream build failures (e.g., network_system CI on Windows MSVC) when cmake --install did not copy these headers.
2 tasks
kcenon
added a commit
that referenced
this pull request
Mar 19, 2026
Fix cmake install rules after header migration (PR #440). Ensures include/kcenon/container/ headers are properly installed for downstream consumers. Unblocks network_system CI.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
Fix cmake install rules after header migration (PR #440). Ensures include/kcenon/container/ headers are properly installed for downstream consumers. Unblocks network_system CI.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Migrates all public headers from
core/toinclude/kcenon/container/to align with the kcenon ecosystem convention used by all other systems (thread_system, common_system, etc.).Change Type
Affected Components
include/kcenon/container/— 24 canonical public headers (new)core/— replaced with forwarding headersinclude/container/optimizations/— replaced with forwarding headerCMakeLists.txt— include paths and install rulesWhy
Related Issues
Motivation
All other 7 systems in the kcenon ecosystem use
include/kcenon/<system>/as the public include root. container_system was the only outlier with headers directly incore/. This migration ensures consistent include paths across the entire ecosystem:```cpp
// New canonical path (preferred)
#include <kcenon/container/container.h>
// Old path still works (backward compatible)
#include "core/container.h"
```
Where
Files Changed Summary
How
Implementation Details
Testing Done
Breaking Changes
None — all existing include paths continue to work through forwarding headers.