Skip to content

fix(cmake): standardize exported target name to container_system::container_system#507

Merged
kcenon merged 1 commit into
mainfrom
fix/issue-78-standardize-target-naming
Apr 10, 2026
Merged

fix(cmake): standardize exported target name to container_system::container_system#507
kcenon merged 1 commit into
mainfrom
fix/issue-78-standardize-target-naming

Conversation

@kcenon

@kcenon kcenon commented Apr 10, 2026

Copy link
Copy Markdown
Owner

What

Summary

Standardize the CMake exported target name from container_system::container to
container_system::container_system, following the <package>::<package> convention.

Change Type

  • Bugfix (fixes an issue)

Affected Components

  • CMakeLists.txt - Changed EXPORT_NAME and added canonical alias
  • cmake/container_system-config.cmake.in - Added backward compatibility alias

Why

Problem Solved

After find_package(container_system), consumers previously got
container_system::container instead of the conventional
container_system::container_system. This deviates from the standard
<package>::<package> naming convention used by most CMake packages.

Related Issues

Where

Files Changed

File Type of Change
CMakeLists.txt Changed EXPORT_NAME, added canonical alias
cmake/container_system-config.cmake.in Added alias + updated target references

How

Implementation Details

  1. Changed EXPORT_NAME from container to container_system in
    set_target_properties() so the exported target becomes
    container_system::container_system.

  2. Added container_system::container_system as a build-tree alias for
    in-tree consumers (unified builds).

  3. Added a backward-compatible alias in the config template:

    if(NOT TARGET container_system::container)
        add_library(container_system::container ALIAS container_system::container_system)
    endif()
  4. Updated ContainerSystem::container legacy alias to link against
    container_system::container_system instead of container_system::container.

  5. Updated container_system_LIBRARIES variable to use the new canonical name.

Breaking Changes

None - existing consumers using container_system::container or
ContainerSystem::container will continue to work via backward-compatible aliases.

…tainer_system

Change EXPORT_NAME from container to container_system so consumers get
container_system::container_system after find_package(container_system),
following the <package>::<package> convention.

Add container_system::container_system as canonical build-tree alias.
Backward-compatible aliases (container_system::container and
ContainerSystem::container) are preserved for existing consumers.

Part of kcenon/vcpkg-registry#78
@github-actions

Copy link
Copy Markdown
Contributor

Performance Benchmark Report

Summary

  • Total benchmarks: 0
  • Regressions: 0 ✅
  • Improvements: 0
  • Unchanged: 0 (within 10% threshold)

Status: No significant performance regressions detected.

@kcenon kcenon merged commit 54bd6dc into main Apr 10, 2026
31 checks passed
@kcenon kcenon deleted the fix/issue-78-standardize-target-naming branch April 10, 2026 05:31
kcenon added a commit that referenced this pull request Apr 13, 2026
…tainer_system (#507)

Change EXPORT_NAME from container to container_system so consumers get
container_system::container_system after find_package(container_system),
following the <package>::<package> convention.

Add container_system::container_system as canonical build-tree alias.
Backward-compatible aliases (container_system::container and
ContainerSystem::container) are preserved for existing consumers.

Part of kcenon/vcpkg-registry#78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant