refactor(container): consolidate headers under include/kcenon/container/#537
Merged
refactor(container): consolidate headers under include/kcenon/container/#537
Conversation
Move all .h files from core/, internal/, integration/, messaging/ into the canonical include/kcenon/container/ tree, and flatten the nested include/kcenon/container/container/ subdirectory. Changes: - internal/*.h -> include/kcenon/container/internal/*.h (16 files) - internal/async/*.h -> include/kcenon/container/internal/async/*.h - integration/messaging_integration.h -> include/kcenon/container/integration/ - messaging/message_container.h -> include/kcenon/container/messaging/ - core/*.h forwarders deleted (21 files); canonical copies were already at include/kcenon/container/*.h - include/kcenon/container/container/*.h flattened to include/kcenon/container/*.h (7 files) - Updated relative includes in canonical headers - Updated #include paths in every translation unit (sources, tests, examples, benchmarks, integration_tests, fuzz, grpc) to use <kcenon/container/...> - Updated CMakeLists.txt to reference headers at new locations Out of scope (handled in subsequent issues): - Moving .cpp files (#533) - Adding [[deprecated]] to legacy forwarders (#534) - Decomposing CMakeLists.txt (#535) - Updating Doxyfile and install(DIRECTORY ...) rules (#536) Closes #532 Part of #531
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates all
.hheaders from feature directories at the repository root into the canonicalinclude/kcenon/container/tree, and flattens the awkwardinclude/kcenon/container/container/nested layout that existed in the previous structure.Affected Components
internal/*.h(16 files) ->include/kcenon/container/internal/internal/async/*.h->include/kcenon/container/internal/async/integration/messaging_integration.h->include/kcenon/container/integration/messaging/message_container.h->include/kcenon/container/messaging/core/*.hforwarders (21 files) deleted - canonical copies were already atinclude/kcenon/container/include/kcenon/container/container/*.h(7 files) flattened toinclude/kcenon/container/Why
include/already contained some headers underkcenon/container/, but feature directories still held 39 headers at the repo root. As a result:#includepaths were ambiguous: the same type was reachable via multiple rootsinclude/kcenon/container/container/fwd.h); this PR also fixes thatWhere
core/,internal/,integration/,messaging/(header files only -.cppis out of scope, see [#531-2/5] Source migration to src/{core,internal,integration,messaging}/ #533)include/kcenon/container/{,internal,integration,messaging}/#includes the moved headers (sources, tests, examples, benchmarks, integration_tests, fuzz, grpc)How
Implementation
git mvheaders preserving subdirectory structure#includepaths inside canonical headers (e.g.,"../value_types.h"->"value_types.h"after flattening)#includesite in the repo to use<kcenon/container/...>pathsCMakeLists.txtsource list to reference headers at new locationscontainer.hforwarder remains in place (will be deprecated in [#531-3/5] Mark legacy include/container/ forwarding [[deprecated]] #534)Acceptance Criteria
core/,internal/,integration/,messaging/contain no header filesinclude/kcenon/container/include/kcenon/container/container/nested directory removed (flattened)Out of Scope (handled in sibling sub-issues)
.cppfiles ([#531-2/5] Source migration to src/{core,internal,integration,messaging}/ #533)[[deprecated]]to legacy forwarders ([#531-3/5] Mark legacy include/container/ forwarding [[deprecated]] #534)cmake/modules ([#531-4/5] Decompose CMakeLists.txt into cmake/ modules #535)install(DIRECTORY ...)rules ([#531-5/5] Update Doxygen input paths and install rules #536)include/container/forwarding header ([#531-3/5] Mark legacy include/container/ forwarding [[deprecated]] #534)Verification
Local toolchain unavailable in the working environment; relying on CI for full build and test verification.
Test Plan
cmake -S . -B build && cmake --build build/ -jctest --test-dir build/ --output-on-failureCloses #532
Part of #531