(feat): Add Sumo Logic scaler

[mittalvaibhav1]

Add Sumo Logic scaler to scale based and logs and metrics from Sumo Logic

1. Issue: Support Sumo Logic scaler #6734
2. Docs PR: (feat): Add sumologic scaler documentation keda-docs#1566

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

[rickbrouwer]

My feedback will focus on the possibility of using TypedConfig.

This scaler does not use the new TypedConfig pattern available in the scalersconfig package. The metadata is manually parsed in parseSumoMetadata instead of declaratively with tags.
You can also store the defaults here, like:

	// Connection settings
	Host      string `keda:"name=host,      order=triggerMetadata"`
	UnsafeSsl bool   `keda:"name=unsafeSsl, order=triggerMetadata, optional"`

	// Authentication
	AccessID  string `keda:"name=access_id,  order=authParams"`
	AccessKey string `keda:"name=access_key, order=authParams"`

	// Query configuration
	QueryType        string            `keda:"name=queryType,        order=triggerMetadata, enum=logs;metrics"`
	Query            string            `keda:"name=query,            order=triggerMetadata, optional"`
	Queries          map[string]string `keda:"name=query.*,          order=triggerMetadata, optional"`
	ResultQueryRowID string            `keda:"name=resultQueryRowID, order=triggerMetadata, optional"`
	Quantization     time.Duration     `keda:"name=quantization,     order=triggerMetadata, optional"`
	Rollup           string            `keda:"name=rollup,           order=triggerMetadata, default=avg"`
	ResultField      string            `keda:"name=resultField,      order=triggerMetadata, optional"`
	Timerange        time.Duration     `keda:"name=timerange,        order=triggerMetadata"`
	Timezone         string            `keda:"name=timezone,         order=triggerMetadata, default=UTC"`
	QueryAggregator  string            `keda:"name=queryAggregator,  order=triggerMetadata, enum=Latest;Avg;Sum;Count;Min;Max, default=Sum"`

	// Scaling parameters
	ActivationThreshold float64 `keda:"name=activationThreshold, order=triggerMetadata, default=0"`
	Threshold           float64 `keda:"name=threshold,           order=triggerMetadata"`

Also there is a some of manual validation logic that can be handled automatically with TypedConfig.

Furthermore, I would keep GetMetricsAndActivity cleaner like the other scalers, like this:

// GetMetricsAndActivity retrieves metrics from sumologic
func (s *sumologicScaler) GetMetricsAndActivity(ctx context.Context, metricName string) ([]external_metrics.ExternalMetricValue, bool, error) {
	num, err := s.executeQuery(ctx)
	if err != nil {
		s.logger.Error(err, "error getting metrics from sumologic")
		return []external_metrics.ExternalMetricValue{}, false, fmt.Errorf("error getting metrics from sumologic: %w", err)
	}

	metric := GenerateMetricInMili(metricName, num)
	isActive := num > s.metadata.ActivationThreshold

	return []external_metrics.ExternalMetricValue{metric}, isActive, nil
}

func (s *sumologicScaler) executeQuery(ctx context.Context) (float64, error) {
	return s.client.GetQueryResult(
		s.metadata.QueryType,
		s.metadata.Query,
		s.metadata.Queries,
		s.metadata.ResultQueryRowID,
		s.metadata.Quantization,
		s.metadata.Rollup,
		s.metadata.ResultField,
		s.metadata.Timerange,
		s.metadata.Timezone,
		s.metadata.QueryAggregator,
	)
}

Further, I am very curious to see how the Multi-Metrics Query Trigger is viewed by the community/maintainers (because of this discussion)

[mittalvaibhav1]

Thanks for reviewing! I'll try out the things you mentioned above.

Further, I am very curious to see how the Multi-Metrics Query Trigger is viewed by the community/maintainers (because of #6697)

I see, it's a bit similar but the use-case is different. In Sumo Logic's case, that is how you write chained queries. Unlike prometheus where you can just let's say divide two metrics to calculate % utilisation or something, in Sumo Logic you have to define those metrics in separate queries and write another query which can reference those queries to do the chained calculation. The backend does all the calculation and we just pick result of the chained query via the input resultQueryRowID and ignore the rest.

For example -

query.A: "metric=requests_total | rate"
query.B: "metric=request_capacity"
query.C: "(#A / #B) * 100 along service"
resultQueryRowID: "C"          # Which query result to extract

Here, we are just interested in the result of query.C but the system expects the input this way. Unlike the usecase in #6697, this is just a single trigger.

[mittalvaibhav1]

I'll try out the things you mentioned above

Done!
Looks much cleaner now. Thanks!

[rickbrouwer]

I'll try out the things you mentioned above

Done! Looks much cleaner now. Thanks!

Great! Looks good! Just curious, in the sumologicMetadata, what are those mapstructure and validate:"required" for? I don't think that's necessary, unless you use it somewhere else in the code (I haven't looked into it yet)

[mittalvaibhav1]

You are right, it's not needed. Removed it. Thanks!

[wozniakjan]

/run-e2e sumologic
Update: You can check the progress here

[wozniakjan]

/run-e2e sumologic
Update: You can check the progress here

[wozniakjan]

/run-e2e sumologic
Update: You can check the progress here

[Copilot]

Pull Request Overview

Adds a new Sumo Logic scaler to KEDA for logs- and metrics-based autoscaling, including implementation, registration, and tests.

• Introduce Sumo Logic scaler under pkg/scalers and register in the builder
• Add unit tests for metadata parsing/metric spec and an e2e test
• Update test environment variables and document the new scaler in CHANGELOG

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/scalers/sumologic/sumologic_test.go	Add end-to-end test for Sumo Logic scaler
tests/.env	Add Sumo Logic environment variables
pkg/scaling/scalers_builder.go	Register the sumologic scaler
pkg/scalers/sumologic_scaler_test.go	Unit tests for metadata parsing and metric naming
pkg/scalers/sumologic_scaler.go	Core Sumo Logic scaler implementation
pkg/scalers/sumologic/types.go	HTTP client and type definitions for Sumo Logic API
pkg/scalers/sumologic/sumologic.go	API logic for log and metrics queries
pkg/scalers/sumologic/query.go	Query builder for Sumo Logic API
pkg/scalers/sumologic/metrics.go	Metrics query creation and response parsing
pkg/scalers/sumologic/logs.go	Logs search, paging, and processing
CHANGELOG.md	Document new Sumo Logic scaler

Comments suppressed due to low confidence (4)

tests/scalers/sumologic/sumologic_test.go:200

• The assertion message says "after 3 minutes" but the timeout is set to 60 seconds; update the message or adjust the timeout to match.

"replica count should be %d after 3 minutes", maxReplicaCount)

tests/scalers/sumologic/sumologic_test.go:211

• The assertion message says "after 3 minutes" but the timeout is set to 60 seconds; either extend the timeout or correct the message.

"replica count should be %d after 3 minutes", minReplicaCount)

tests/scalers/sumologic/sumologic_test.go:216

• Use t.Skip or t.Skipf when SUMO_LOGIC_COLLECTOR_URL is not set to explicitly skip the data-push loop, preventing silent test passes with no data pushed.

t.Logf("No collector URL set, failed data push to Sumo Logic")

tests/scalers/sumologic/sumologic_test.go:161

• [nitpick] Add checks at the start of this test to verify SUMO_LOGIC_ACCESS_ID, SUMO_LOGIC_ACCESS_KEY, and SUMO_LOGIC_COLLECTOR_URL are set and call t.Skipf if any are missing to avoid misleading failures.

func TestSumologicScaler(t *testing.T) {

[wozniakjan]

lgtm, thank you!

[wozniakjan]

ptal @JorTurFer, @zroubalik

[wozniakjan]

/run-e2e sumologic
Update: You can check the progress here

[wozniakjan]

@JorTurFer, @zroubalik, given this has approval from @rickbrouwer and myself, I am going to merge this so we have time to watch the e2es and debug until 2.18 release. In the worst case, we can always revert.

[rickbrouwer]

It looks like the e2e test is failing on the main. Is that something that needs to be looked into?

https://github.com/kedacore/keda/actions/runs/16222531975

[mittalvaibhav1]

@rickbrouwer Ack, looking into it.

[mittalvaibhav1]

Looks like the search job API isn't allowed for this free account type. Can we mute this E2E or revert the PR until I can sort this out internally?

[rickbrouwer]

I think we can wait a little longer until you have figured it out. As @wozniakjan earlier said :

we have time to watch the e2es and debug until 2.18 release

so, keep us updated :)

[mittalvaibhav1]

Thank you! I should have a response by Monday.

[rickbrouwer]

/run-e2e sumologic
Update: You can check the progress here

[wozniakjan]

I missed this earlier, but looks like the sumologic e2e test even though it passed, it had issues even before, can you please take a look at that too @mittalvaibhav1?

2025-07-07T20:42:42.2386347Z ***0***5-07-07T***0:4***:***5Z	ERROR	scale_handler	error getting scale decision	***"scaledObject.Namespace": "sumologic-keda-test-ns", "scaledObject.Name": "sumologic-keda-test-so", "scaler": "sumologicScaler", "error": "error getting metrics from sumologic: only agg queries are supported, please check your query"***
2025-07-07T20:42:42.2388719Z github.com/***/keda/v***/pkg/scaling.(*scaleHandler).getScalerState
2025-07-07T20:42:42.2390543Z 	/workspace/pkg/scaling/scale_handler.go:78***
2025-07-07T20:42:42.2393956Z github.com/***/keda/v***/pkg/scaling.(*scaleHandler).getScaledObjectState.func***
2025-07-07T20:42:42.2395775Z 	/workspace/pkg/scaling/scale_handler.go:6***4

[rickbrouwer]

Yeah, also in the latest run I see those logs:

https://github.com/kedacore/keda/actions/runs/16264440131/job/45917864210#step:9:569

[mittalvaibhavs]

It's a logical error when query results in no data. This should fix it
#6906