Skip to content

release-tool: Create output dir if it does not exist and revert previous build-src patch#13143

Merged
phoerious merged 1 commit intodevelopfrom
fix/release-tool
Mar 12, 2026
Merged

release-tool: Create output dir if it does not exist and revert previous build-src patch#13143
phoerious merged 1 commit intodevelopfrom
fix/release-tool

Conversation

@phoerious
Copy link
Copy Markdown
Member

Revert commit 36a2630 and add a proper fix for the issue. The error was not the source file vanishing, it was the target directory not existing.

The previous patch was incorrect and caused truncation issues of the source tarball. The result was a missing .gitrev file.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@phoerious phoerious requested a review from a team March 12, 2026 21:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.59%. Comparing base (36a2630) to head (ade0550).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13143      +/-   ##
===========================================
- Coverage    64.60%   64.59%   -0.00%     
===========================================
  Files          378      378              
  Lines        39907    39907              
===========================================
- Hits         25778    25777       -1     
- Misses       14129    14130       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@phoerious phoerious changed the title Create output dir if it does not exist and revert previous patch release-tool: Create output dir if it does not exist and revert previous patch Mar 12, 2026
@phoerious phoerious changed the title release-tool: Create output dir if it does not exist and revert previous patch release-tool: Create output dir if it does not exist and revert previous build-src patch Mar 12, 2026
@phoerious phoerious merged commit d5f7614 into develop Mar 12, 2026
12 checks passed
@phoerious phoerious deleted the fix/release-tool branch March 12, 2026 22:34
@phoerious phoerious added the pr:backport-pending Pull request to be backported label Mar 12, 2026
@phoerious phoerious added this to the v.2.7.13 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build system pr:backport-pending Pull request to be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants