update python version #2489
update python version #2489
Conversation
Summary of ChangesHello @divyashreepathihalli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's documentation to align with a new minimum required Python version. It ensures that both the contribution guidelines and the main project README accurately state Python 3.11 as the baseline, which streamlines the development environment setup for contributors and provides up-to-date information. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the required Python version from 3.10 to 3.11 in the project's documentation. The changes in CONTRIBUTING.md and README.md correctly reflect this update in the setup instructions and the Python version badge. The modifications are consistent and clear. I have reviewed the changes and found no issues.
Makes KerasHub tests fail: keras-team/keras-hub#2489
There was a regression for `numpy.mean` on OpenVino for dynamic shape: keras-team#21746 Which makes KerasHub tests fail: keras-team/keras-hub#2489 This PR was manually tested against KerasHub.
There was a regression for `numpy.mean` on OpenVino for dynamic shape: #21746 Which makes KerasHub tests fail: keras-team/keras-hub#2489 This PR was manually tested against KerasHub.
* Update gemma3_causal_lm_preprocessor.py Added checks for invalid inputs * Update gemma3_causal_lm_preprocessor.py * Update gemma3_causal_lm_preprocessor_test.py Added tests to check invalid inputs * Update reversible_embedding.py Fix for model not loading when using numpy behaviour with tensorflow * upadated Gemma3InterleaveEmbeddings * Update gemma3_interleave_embeddings.py * Revert "Update reversible_embedding.py" This reverts commit 3fdc7fd. * Update gemma3_interleave_embeddings.py * Fix ReversibleEmbedding quantization for Keras 3.13 compatibility - Update _int8_build method to accept config parameter - Ensure backward compatibility with Keras 3.12 - Resolves TypeError in quantization tests
…am#2482) * Models should reference ReversibleEmbedding from Keras core * backwards compat * remove keras 3.9 from test matrix * python version changes * disable cache when fetching nightly
|
For the failing JAX tests, I think you need to change this line: https://github.com/keras-team/keras-hub/blob/master/keras_hub/src/models/causal_lm.py#L199 to [v.value for v in self.sampler.variables], |
6 participants
No description provided.