Add initial codeowner groups #12635
Add initial codeowner groups #12635
Conversation
Signed-off-by: npolshakova <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CODEOWNERS file to establish code ownership groups for the kgateway project, implementing automated review requirements for critical components.
- Adds code ownership rules for API-related files and CI infrastructure
- Establishes two ownership groups: API owners and CI owners
- Sets up automated review requirements for critical paths like
/api/,/install/,.github/, and Go modules
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
kind/feature
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
CODEOWNERS
Outdated
| # CI workflows | ||
| /.github @kgateway-dev/kgateway-ci-owners | ||
| /.githooks @kgateway-dev/kgateway-ci-owners | ||
| /.gitignore @kgateway-dev/kgateway-ci-owners |
There was a problem hiding this comment.
| /.gitignore @kgateway-dev/kgateway-ci-owners |
I'd vote to let anyone modify .gitignore since it's mostly used to hide folders used in dev workflows or tools.
There was a problem hiding this comment.
i'm ok either way on the .gitignore
| # API definitions and CRDs - critical for API compatibility | ||
| /api/ @kgateway-dev/kgateway-api-owners | ||
| # Require approval for everything under install/ | ||
| /install/ @kgateway-dev/kgateway-api-owners |
There was a problem hiding this comment.
note that this folder includes not just api-related files, but also helm templates (under install/helm/kgateway/templates). do we need special approval for those files? (if yes, i would say we should also add the same codeowners for internal/kgateway/helm)
There was a problem hiding this comment.
Yep, good call!
Signed-off-by: npolshakova <[email protected]>
|
Community PR to introduce groups: kgateway-dev/community#136 |
shashankram
added
the
do-not-merge/work-in-progress
|
More granular code ownership and reviewer assignment is definitely required, though I'd like to explore a different mechanism than file based code ownership. Let's discuss this before merging this. |
github-actions
bot
added
kind/cleanup
4 participants
Description
Add initial code owner groups for API Maintainers and Owners for CI
Change Type
/kind cleanup
Changelog