Skip to content

Add initial codeowner groups #12635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+22 −0
Open

Add initial codeowner groups #12635

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83fe86a
initial codeowner groups
npolshakova Oct 15, 2025
c522416
more ci workflow approval files
npolshakova Oct 15, 2025
09a70b1
fix name
npolshakova Oct 15, 2025
ae11100
feedback
npolshakova Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# CODEOWNERS file for kgateway
# See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# API definitions and CRDs - critical for API compatibility
/api/ @kgateway-dev/kgateway-api-owners
# Require approval for everything under install/
/install/ @kgateway-dev/kgateway-api-owners
Copy link
Contributor

@jenshu jenshu Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this folder includes not just api-related files, but also helm templates (under install/helm/kgateway/templates). do we need special approval for those files? (if yes, i would say we should also add the same codeowners for internal/kgateway/helm)

Copy link
Contributor Author

@npolshakova npolshakova Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good call!

# Require approval for helm templates
/internal/kgateway/helm @kgateway-dev/kgateway-api-owners

# CI workflows
/.github @kgateway-dev/kgateway-ci-owners
/.githooks @kgateway-dev/kgateway-ci-owners
/.gitattributes @kgateway-dev/kgateway-ci-owners
/.golangci.yaml @kgateway-dev/kgateway-ci-owners
/.goreleaser.yaml @kgateway-dev/kgateway-ci-owners
Makefile* @kgateway-dev/kgateway-ci-owners
# core dependency management code
/go.mod @kgateway-dev/kgateway-ci-owners
/go.sum @kgateway-dev/kgateway-ci-owners

# Note: Other directories are intentionally not assigned specific owners at this time to avoid process overhead.
Loading