-
Notifications
You must be signed in to change notification settings - Fork 596
WIP: Local kind registry #12798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: Local kind registry #12798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the local development setup to use a local container registry with Kind instead of directly loading images into the cluster. The change streamlines the build process by pushing images to a local registry (localhost:5001) that Kind clusters can pull from.
Key changes:
- Adds a new script
setup-local-registry.shto create and configure a local Docker registry - Updates the build process to push images to the local registry instead of loading them directly into Kind
- Removes the
kind-load-*andkind-build-and-load-*targets in favor of a unifieddocker-buildtarget
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hack/kind/setup-local-registry.sh | New script that creates a local Docker registry and configures Kind cluster to use it |
| hack/kind/setup-kind.sh | Updated to use the new local registry setup script and build process |
| hack/kind/cluster.yaml | Simplified cluster config with containerd registry configuration |
| Makefile | Changed default IMAGE_REGISTRY to localhost:5001, replaced kind-load targets with docker-build using buildx |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: timflannagan <[email protected]>
0c4ab43 to
b46b43c
Compare
|
kubernetes-sigs/kind#3634 is one end of a rabbit hole whose tl;dr is that the Kind maintainers prefer a local registry for preloading images to the alternative of building a kindest/node image with other images baked in. Based on static analysis, it'd be nice if it were easy to load the following (which assumes that #12834 lands) into the local registry since we sometimes use them during development (some might be envtest-only, never actually pulled): |
Description
WIP
Change Type
/kind cleanup
Changelog
Additional Notes