Skip to content

Conversation

@timflannagan
Copy link
Member

@timflannagan timflannagan commented Oct 31, 2025

Description

WIP

Change Type

/kind cleanup

Changelog

NONE

Additional Notes

Copilot AI review requested due to automatic review settings October 31, 2025 18:03
@github-actions github-actions bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the local development setup to use a local container registry with Kind instead of directly loading images into the cluster. The change streamlines the build process by pushing images to a local registry (localhost:5001) that Kind clusters can pull from.

Key changes:

  • Adds a new script setup-local-registry.sh to create and configure a local Docker registry
  • Updates the build process to push images to the local registry instead of loading them directly into Kind
  • Removes the kind-load-* and kind-build-and-load-* targets in favor of a unified docker-build target

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
hack/kind/setup-local-registry.sh New script that creates a local Docker registry and configures Kind cluster to use it
hack/kind/setup-kind.sh Updated to use the new local registry setup script and build process
hack/kind/cluster.yaml Simplified cluster config with containerd registry configuration
Makefile Changed default IMAGE_REGISTRY to localhost:5001, replaced kind-load targets with docker-build using buildx

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan added the work in progress Indicates that a PR should not merge because it is a work in progress label Nov 5, 2025
@chandler-solo
Copy link
Contributor

kubernetes-sigs/kind#3634 is one end of a rabbit hole whose tl;dr is that the Kind maintainers prefer a local registry for preloading images to the alternative of building a kindest/node image with other images baked in.

Based on static analysis, it'd be nice if it were easy to load the following (which assumes that #12834 lands) into the local registry since we sometimes use them during development (some might be envtest-only, never actually pulled):

amazon/aws-cli:2.31.29
curlimages/curl:7.83.1
docker:26-dind
docker.io/envoyproxy/ratelimit:3e085e5b
docker.io/fullstorydev/grpcurl:v1.8.7-alpine
docker.io/istio/examples-bookinfo-reviews-v3:1.20.1
docker.io/kennethreitz/httpbin@sha256:599fe5e5073102dbb0ee3dbb65f049dab44fa9fc251f6835c9990f8fb196a72b
docker.io/mccutchen/go-httpbin:v2.15.0
docker.io/mccutchen/go-httpbin:v2.6.0
gcr.io/istio-testing/ext-authz:1.25-dev
gcr.io/k8s-staging-gateway-api/echo-basic:v20231214-v1.0.0-140-gf544a46e
gcr.io/solo-public/docs/ai-guardrail-webhook@sha256:01f81b20ae016d123f018841c62daff7f6f44d0dec9189ecf591b3e99753c6b1
gcr.io/solo-test-236622/ext-proc-example-basic-sink:0.0.2
gcr.io/solo-test-236622/http-echo:0.2.4
ghcr.io/agentgateway/agentgateway:0.11.0-alpha.2f71d0e845d0105037cbb5524262a5f1c1bd94a9
ghcr.io/kgateway-dev/curl:7.83.1
ghcr.io/kgateway-dev/mcp-admin-server:0.0.1
ghcr.io/kgateway-dev/mcp-website-fetcher:0.0.1
ghcr.io/kgateway-dev/test-a2a-server:0.0.11
ghcr.io/llm-d/llm-d-inference-sim:v0.3.0
ghcr.io/projectcontour/yages:v0.1.0
golang:1.24
hashicorp/http-echo:1.0.0
jmalloc/echo-server:v0.3.7
nginx:1.28.0
otel/opentelemetry-collector-contrib:0.116.1
quay.io/metallb/controller:v0.13.7
quay.io/metallb/speaker:v0.13.7
quay.io/solo-io/access-logger:1.18.13
quay.io/solo-io/envoy-gloo:1.36.2-patch1
redis:7.4.3
ricoli/hey@sha256:306dcd944a4398264f8a6bb43501afb3bb2285be4be248859bac971c57e3c270
soloio/tcp-echo@sha256:6ad961aa515283242f8f18bfedb41f93ffe8cc983846da139f247fbab7519f16
us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none work in progress Indicates that a PR should not merge because it is a work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants